[Web Payments] Add PopMany and Size functions to ViewStack

[Web Payments] Add PopMany and Size functions to ViewStack

BUG=709571
Review-Url: https://codereview.chromium.org/2817533006
Cr-Commit-Position: refs/heads/master@{#464651}
Committed: https://chromium.googlesource.com/chromium/src/+/f9052324d316824ccedb2204bc68b24cce5dc7c6

[anthonyvd, 2017-04-13 13:26:24]

The CQ bit was checked by anthonyvd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 13:26:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 14:00:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 14:00:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[anthonyvd, 2017-04-13 16:42:06]

anthonyvd@chromium.org changed reviewers:
+ mathp@chromium.org

[anthonyvd, 2017-04-13 16:42:06]

Hi Math, can you PTAL while I fix browser tests and add some ViewStack
unittests? Thanks!

[Mathieu, 2017-04-13 16:55:24]

cool waiting for the tests then

https://codereview.chromium.org/2817533006/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_dialog_view.cc (right):

https://codereview.chromium.org/2817533006/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_dialog_view.cc:156: if
(view_stack_->size() > 1)
Add comment:

// This assumes that the Payment Sheet is the first view in the stack. Thus if
there is only one view, we are already showing the payment sheet.

https://codereview.chromium.org/2817533006/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/view_stack.cc (right):

https://codereview.chromium.org/2817533006/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/view_stack.cc:63:
DCHECK_LT(static_cast<size_t>(n), size());  // The stack can never be empty.
how does Pop handle popping the last view?

https://codereview.chromium.org/2817533006/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/view_stack.h (right):

https://codereview.chromium.org/2817533006/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/view_stack.h:36: // Removes |n| views from the
stack but only animates the topmost one.
Optionally: // The end result is an animation from the top-most view to the
destination view.

[anthonyvd, 2017-04-13 20:22:19]

The CQ bit was checked by anthonyvd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 20:22:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[anthonyvd, 2017-04-13 20:22:58]

Comments addressed, tests fixed, more tests added. PTAL!

https://codereview.chromium.org/2817533006/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_request_dialog_view.cc (right):

https://codereview.chromium.org/2817533006/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_request_dialog_view.cc:156: if
(view_stack_->size() > 1)
On 2017/04/13 at 16:55:23, Mathieu wrote:
> Add comment:
> 
> // This assumes that the Payment Sheet is the first view in the stack. Thus if
there is only one view, we are already showing the payment sheet.

Done.

https://codereview.chromium.org/2817533006/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/view_stack.cc (right):

https://codereview.chromium.org/2817533006/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/view_stack.cc:63:
DCHECK_LT(static_cast<size_t>(n), size());  // The stack can never be empty.
On 2017/04/13 at 16:55:23, Mathieu wrote:
> how does Pop handle popping the last view?

It doesn't. The view would animate out but hit "DCHECK(!stack_.empty()) <<
"State stack should never be empty";" after removing it. This DCHECK here
ensures that we're always calling PopMany such that there's still at least one
view remaining on the stack.

https://codereview.chromium.org/2817533006/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/view_stack.h (right):

https://codereview.chromium.org/2817533006/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/view_stack.h:36: // Removes |n| views from the
stack but only animates the topmost one.
On 2017/04/13 at 16:55:23, Mathieu wrote:
> Optionally: // The end result is an animation from the top-most view to the
destination view.

Done.

[commit-bot: I haz the power, 2017-04-13 20:52:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 20:52:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2017-04-13 21:01:12]

lgtm

[anthonyvd, 2017-04-13 23:23:42]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2017-04-13 23:23:43]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2817533006/#ps40001
(title: "Fix browser tests")

[commit-bot: I haz the power, 2017-04-13 23:24:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 00:03:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 00:03:52]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[anthonyvd, 2017-04-14 00:55:09]

The CQ bit was checked by anthonyvd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 00:55:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 01:37:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 01:37:10]

Dry run: This issue passed the CQ dry run.

[anthonyvd, 2017-04-14 01:39:04]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2017-04-14 01:39:05]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/2817533006/#ps60001
(title: "Remove unused Observer that caused use-after-free in tests.")

[commit-bot: I haz the power, 2017-04-14 01:39:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 01:44:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492133944750340,
"parent_rev": "d82f2908e3193915cdc573d54f962920714b847d", "commit_rev":
"f9052324d316824ccedb2204bc68b24cce5dc7c6"}

[commit-bot: I haz the power, 2017-04-14 01:45:15]

Description was changed from

==========
[Web Payments] Add PopMany and Size functions to ViewStack

BUG=709571
==========

to

==========
[Web Payments] Add PopMany and Size functions to ViewStack

BUG=709571

Review-Url: https://codereview.chromium.org/2817533006
Cr-Commit-Position: refs/heads/master@{#464651}
Committed:
https://chromium.googlesource.com/chromium/src/+/f9052324d316824ccedb2204bc68...
==========

[commit-bot: I haz the power, 2017-04-14 01:45:16]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f9052324d316824ccedb2204bc68...