chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc - Issue 2817533006: [Web Payments] Add PopMany and Size functions to ViewStack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

Issue 2817533006: [Web Payments] Add PopMany and Size functions to ViewStack (Closed)

Patch Set: Remove unused Observer that caused use-after-free in tests. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

diff --git a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

index a8e87aceb8dadea0519688fd367e5272e65d8424..245da2bab9680b788092f57bdb7e1857e564a8f3 100644

--- a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

+++ b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

@@ -70,7 +70,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest, EnteringValidData) {

autofill::PersonalDataManager* personal_data_manager = GetDataManager();

personal_data_manager->AddObserver(&personal_data_observer_);

- ResetEventObserver(DialogEvent::BACK_NAVIGATION);

+ ResetEventObserver(DialogEvent::BACK_TO_PAYMENT_SHEET_NAVIGATION);

// Wait until the web database has been updated and the notification sent.

base::RunLoop data_loop;

@@ -284,7 +284,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest,

autofill::PersonalDataManager* personal_data_manager = GetDataManager();

personal_data_manager->AddObserver(&personal_data_observer_);

- ResetEventObserver(DialogEvent::BACK_NAVIGATION);

+ ResetEventObserver(DialogEvent::BACK_TO_PAYMENT_SHEET_NAVIGATION);

// Wait until the web database has been updated and the notification sent.

base::RunLoop data_loop;

@@ -343,7 +343,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest, EditingExpiredCard) {

autofill::PersonalDataManager* personal_data_manager = GetDataManager();

personal_data_manager->AddObserver(&personal_data_observer_);

- ResetEventObserver(DialogEvent::BACK_NAVIGATION);

+ ResetEventObserver(DialogEvent::BACK_TO_PAYMENT_SHEET_NAVIGATION);

// Wait until the web database has been updated and the notification sent.

base::RunLoop data_loop;

« no previous file with comments | « no previous file | chrome/browser/ui/views/payments/editor_view_controller.cc » ('j') | no next file with comments »