chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc - Issue 2817533006: [Web Payments] Add PopMany and Size functions to ViewStack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

Issue 2817533006: [Web Payments] Add PopMany and Size functions to ViewStack (Closed)

Patch Set: Remove unused Observer that caused use-after-free in tests. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/payments/payment_request_dialog_view.cc ('k') | chrome/browser/ui/views/payments/view_stack.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

diff --git a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc b/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

index 00313125aa2e4ad337e6626b91b2acea6a1266c1..6936308de84a617151e0a76130a5945bf02d1860 100644

--- a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

+++ b/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

@@ -158,7 +158,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestShippingAddressEditorTest,

SetRequiredFields();

- ResetEventObserver(DialogEvent::BACK_NAVIGATION);

+ ResetEventObserver(DialogEvent::BACK_TO_PAYMENT_SHEET_NAVIGATION);

// Verifying the data is in the DB.

autofill::PersonalDataManager* personal_data_manager = GetDataManager();

@@ -275,7 +275,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestShippingAddressEditorTest,

SetEditorTextfieldValue(base::ASCIIToUTF16("any state"),

autofill::ADDRESS_HOME_STATE);

SetRequiredFields();

- ResetEventObserver(DialogEvent::BACK_NAVIGATION);

+ ResetEventObserver(DialogEvent::BACK_TO_PAYMENT_SHEET_NAVIGATION);

// Verifying the data is in the DB.

autofill::PersonalDataManager* personal_data_manager = GetDataManager();

« no previous file with comments | « chrome/browser/ui/views/payments/payment_request_dialog_view.cc ('k') | chrome/browser/ui/views/payments/view_stack.h » ('j') | no next file with comments »