gpu: Allow GpuProcessHostUIShim to leak during teardown.

gpu: Allow GpuProcessHostUIShim to leak during teardown.

Remove GpuProcessHostUIShim::DestroyAll(), and related comments which no
longer is accurate. Also, allow the instance(s) to leak during tear down.

BUG=none

Review-Url: https://codereview.chromium.org/2817503005
Cr-Commit-Position: refs/heads/master@{#464287}
Committed: https://chromium.googlesource.com/chromium/src/+/0e56c1a921c6b4fcfcd8f89c2ed821713dc6e23f

[sadrul, 2017-04-12 20:34:14]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 20:35:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-04-12 20:39:16]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2017-04-12 20:39:37]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-12 20:40:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 21:34:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 21:34:25]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-04-12 21:35:42]

Description was changed from

==========
gpu: Allow GpuProcessHostUIShim to leak during teardown.

...

BUG=...
==========

to

==========
gpu: Allow GpuProcessHostUIShim to leak during teardown.

Remove GpuProcessHostUIShim::DestroyAll(), and related comments which no
longer is accurate. Also, allow the instance(s) to leak during tear down.

BUG=none
==========

[sadrul, 2017-04-12 21:37:20]

sadrul@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2017-04-12 22:03:33]

Truth be told, do we need GpuProcessHostUIShim at all? It doesn't carry any
field (except host_id_) and even then, the only reason for host_id_ is to manage
the map, which is used to lookup the GpuProcessHostUIShim in
RouteToGpuProcessHostUIShimTask, but again OnMessageReceived doesn't use
host_id_. So the only reason for the map is at best to cancel messages after
Destroy was called. But because Destroy is also called via tasks posted from the
IO thread by the GpuProcessHost, it won't actually happen that we cancel
messages (task ordering), so the map is properly useless.

IOW, I think we can remove GpuProcessHostUIShim altogether, and just fold the
few remaining things into GpuProcessHost.

LGTM either way.

[sadrul, 2017-04-13 00:17:32]

On 2017/04/12 22:03:33, piman wrote:
> Truth be told, do we need GpuProcessHostUIShim at all? It doesn't carry any
> field (except host_id_) and even then, the only reason for host_id_ is to
manage
> the map, which is used to lookup the GpuProcessHostUIShim in
> RouteToGpuProcessHostUIShimTask, but again OnMessageReceived doesn't use
> host_id_. So the only reason for the map is at best to cancel messages after
> Destroy was called. But because Destroy is also called via tasks posted from
the
> IO thread by the GpuProcessHost, it won't actually happen that we cancel
> messages (task ordering), so the map is properly useless.
> 
> IOW, I think we can remove GpuProcessHostUIShim altogether, and just fold the
> few remaining things into GpuProcessHost.

Getting completely rid of GpuProcessHostUIShim is my plan :) Its only use now is
to send messages to the ozone-platform, and I haven't looked at that closely yet
to see how tricky it would be to untangle that. I was going to wait for
mojofication of the ozone-gpu messages, but looking at that, it should not be
hard to do now. So I will look into that. Thanks!

> 
> LGTM either way.

[sadrul, 2017-04-13 03:38:22]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-04-13 03:38:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-04-13 03:39:05]

I am going to go ahead and put this CL in CQ. I have a CL in progress that will
remove the rest of GpuProcessHostUIShim.

[commit-bot: I haz the power, 2017-04-13 03:54:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492054702725100,
"parent_rev": "caa1091521ea95e80098fc99449c556d2c9fb28e", "commit_rev":
"0e56c1a921c6b4fcfcd8f89c2ed821713dc6e23f"}

[commit-bot: I haz the power, 2017-04-13 03:55:15]

Description was changed from

==========
gpu: Allow GpuProcessHostUIShim to leak during teardown.

Remove GpuProcessHostUIShim::DestroyAll(), and related comments which no
longer is accurate. Also, allow the instance(s) to leak during tear down.

BUG=none
==========

to

==========
gpu: Allow GpuProcessHostUIShim to leak during teardown.

Remove GpuProcessHostUIShim::DestroyAll(), and related comments which no
longer is accurate. Also, allow the instance(s) to leak during tear down.

BUG=none

Review-Url: https://codereview.chromium.org/2817503005
Cr-Commit-Position: refs/heads/master@{#464287}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e56c1a921c6b4fcfcd8f89c2ed8...
==========

[commit-bot: I haz the power, 2017-04-13 03:55:17]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e56c1a921c6b4fcfcd8f89c2ed8...