Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Unified Diff: content/browser/gpu/gpu_process_host.cc

Issue 2817503005: gpu: Allow GpuProcessHostUIShim to leak during teardown. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/browser_main_loop.cc ('k') | content/browser/gpu/gpu_process_host_ui_shim.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_process_host.cc
diff --git a/content/browser/gpu/gpu_process_host.cc b/content/browser/gpu/gpu_process_host.cc
index 39d00af7190e01f0b1fd35f344a640caddfa0cd9..d0d3d06210a2f4ad39396b73d625afc0ea9440af 100644
--- a/content/browser/gpu/gpu_process_host.cc
+++ b/content/browser/gpu/gpu_process_host.cc
@@ -467,11 +467,10 @@ GpuProcessHost::GpuProcessHost(int host_id, GpuProcessKind kind)
g_gpu_process_hosts[kind] = this;
- // Post a task to create the corresponding GpuProcessHostUIShim. The
- // GpuProcessHostUIShim will be destroyed if either the browser exits,
- // in which case it calls GpuProcessHostUIShim::DestroyAll, or the
- // GpuProcessHost is destroyed, which happens when the corresponding GPU
- // process terminates or fails to launch.
+ // Post a task to create the corresponding GpuProcessHostUIShim. The
+ // GpuProcessHostUIShim will be destroyed when the GpuProcessHost is
+ // destroyed, which happens when the corresponding GPU process terminates or
+ // fails to launch. On browser exit, the shim can be leaked.
BrowserThread::PostTask(
BrowserThread::UI,
FROM_HERE,
« no previous file with comments | « content/browser/browser_main_loop.cc ('k') | content/browser/gpu/gpu_process_host_ui_shim.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698