Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: content/browser/gpu/gpu_process_host_ui_shim.h

Issue 2817503005: gpu: Allow GpuProcessHostUIShim to leak during teardown. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/gpu/gpu_process_host.cc ('k') | content/browser/gpu/gpu_process_host_ui_shim.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_process_host_ui_shim.h
diff --git a/content/browser/gpu/gpu_process_host_ui_shim.h b/content/browser/gpu/gpu_process_host_ui_shim.h
index 55754be75c9b6618060e86bc9b980bfb92d6c788..b7f19fb25d045f89ca434af6b627ef3da6a18e67 100644
--- a/content/browser/gpu/gpu_process_host_ui_shim.h
+++ b/content/browser/gpu/gpu_process_host_ui_shim.h
@@ -38,8 +38,7 @@ class BinderRegistry;
namespace content {
void RouteToGpuProcessHostUIShimTask(int host_id, const IPC::Message& msg);
-class GpuProcessHostUIShim : public IPC::Listener,
- public base::NonThreadSafe {
+class GpuProcessHostUIShim : public base::NonThreadSafe {
public:
// Create a GpuProcessHostUIShim with the given ID. The object can be found
// using FromID with the same id.
@@ -50,16 +49,12 @@ class GpuProcessHostUIShim : public IPC::Listener,
// UI shim.
static void Destroy(int host_id, const std::string& message);
- // Destroy all remaining GpuProcessHostUIShims.
- CONTENT_EXPORT static void DestroyAll();
-
CONTENT_EXPORT static GpuProcessHostUIShim* FromID(int host_id);
- // IPC::Listener implementation.
// The GpuProcessHost causes this to be called on the UI thread to
// dispatch the incoming messages from the GPU process, which are
// actually received on the IO thread.
- bool OnMessageReceived(const IPC::Message& message) override;
+ void OnMessageReceived(const IPC::Message& message);
// Register Mojo interfaces that must be bound on the UI thread.
static void RegisterUIThreadMojoInterfaces(
@@ -67,7 +62,7 @@ class GpuProcessHostUIShim : public IPC::Listener,
private:
explicit GpuProcessHostUIShim(int host_id);
- ~GpuProcessHostUIShim() override;
+ ~GpuProcessHostUIShim();
// The serial number of the GpuProcessHost / GpuProcessHostUIShim pair.
int host_id_;
« no previous file with comments | « content/browser/gpu/gpu_process_host.cc ('k') | content/browser/gpu/gpu_process_host_ui_shim.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698