Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2814123005: Move storage quota unit tests and test doubles next to the files they cover. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
Reviewers:
Lei Zhang, kinuko
CC:
chromium-reviews, michaeln, msramek+watch_chromium.org, tzik, jam, wjmaclean, nhiroki, darin-cc_chromium.org, jkarlin+watch_chromium.org, cmumford, markusheintz_, jsbell+idb_chromium.org, kinuko+fileapi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move storage quota unit tests and test doubles next to the files they cover. BUG=2817133002 Review-Url: https://codereview.chromium.org/2814123005 Cr-Commit-Position: refs/heads/master@{#464859} Committed: https://chromium.googlesource.com/chromium/src/+/bf8ae17c1bc517749889c3cb5a8adaebf6d7fbee

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Move test from test_support to tests target :) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4414 lines) Patch
M chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_storage_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/cache_storage/cache_storage_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_operation_impl_write_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_factory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_quota_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/quota/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D content/browser/quota/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
D content/browser/quota/mock_quota_manager.h View 1 chunk +0 lines, -154 lines 0 comments Download
D content/browser/quota/mock_quota_manager.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D content/browser/quota/mock_quota_manager_proxy.h View 1 chunk +0 lines, -90 lines 0 comments Download
D content/browser/quota/mock_quota_manager_proxy.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D content/browser/quota/mock_quota_manager_unittest.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D content/browser/quota/quota_manager_unittest.cc View 1 chunk +0 lines, -2271 lines 0 comments Download
D content/browser/quota/quota_temporary_storage_evictor_unittest.cc View 1 chunk +0 lines, -402 lines 0 comments Download
D content/browser/quota/storage_monitor_unittest.cc View 1 chunk +0 lines, -705 lines 0 comments Download
M content/browser/storage_partition_impl_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
D content/public/test/mock_storage_client.h View 1 chunk +0 lines, -109 lines 0 comments Download
D content/public/test/mock_storage_client.cc View 1 chunk +0 lines, -191 lines 0 comments Download
M content/test/BUILD.gn View 1 2 chunks +0 lines, -10 lines 0 comments Download
M storage/browser/BUILD.gn View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
A + storage/browser/quota/quota_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/quota/quota_temporary_storage_evictor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/quota/storage_monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/mock_quota_manager.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/mock_quota_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/mock_quota_manager_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/mock_quota_manager_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
A + storage/browser/test/mock_quota_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + storage/browser/test/mock_storage_client.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/test/mock_storage_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (17 generated)
pwnall
kinuko: PTAL? This CL is a bit less trivial than the previous moving CLs, because ...
3 years, 8 months ago (2017-04-14 00:21:51 UTC) #4
Lei Zhang
On 2017/04/14 00:21:51, pwnall wrote: > thestig: Please review changes in > chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc lgtm
3 years, 8 months ago (2017-04-14 00:31:06 UTC) #5
kinuko
lgtm!
3 years, 8 months ago (2017-04-14 02:29:09 UTC) #8
kinuko
Some quota tests are failing, might be a real issue?
3 years, 8 months ago (2017-04-14 02:29:46 UTC) #9
pwnall
On 2017/04/14 02:29:46, kinuko wrote: > Some quota tests are failing, might be a real ...
3 years, 8 months ago (2017-04-15 04:25:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814123005/40001
3 years, 8 months ago (2017-04-15 04:59:21 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-04-15 08:52:50 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bf8ae17c1bc517749889c3cb5a8a...

Powered by Google App Engine
This is Rietveld 408576698