v8binding: Implements an alternative of WindowProxy.[[DefineOwnProperty]].

v8binding: Implements an alternative of WindowProxy.[[DefineOwnProperty]].

Implements the following part of the spec with using indexed interceptor.
https://html.spec.whatwg.org/C/browsers.html#windowproxy-defineownproperty
step 2 - 1. If P is an array index property name, return false.

The spec's actual effect is mostly that author script cannot define
a property with an array index property name on a window object.

With this CL, the following ES code has no effect.
  window[0] = 42;
  Object.defineProperty(window, 0, {value: 42});

BUG=695385
Review-Url: https://codereview.chromium.org/2816743002
Cr-Commit-Position: refs/heads/master@{#464912}
Committed: https://chromium.googlesource.com/chromium/src/+/c105f1574d48e229385fbef9293aca66fc087f9b

[Yuki, 2017-04-12 14:54:21]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 14:54:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 16:15:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 16:15:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yuki, 2017-04-14 11:47:17]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 11:47:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2017-04-14 13:20:54]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuki, 2017-04-14 13:20:55]

Could you review this CL?

[commit-bot: I haz the power, 2017-04-14 13:37:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 13:37:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2017-04-14 18:50:07]

LGTM

We should probably get an approval from an API owner.

https://codereview.chromium.org/2816743002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/DOMWindow.h (left):

https://codereview.chromium.org/2816743002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/DOMWindow.h:85: // FIXME: This handles both
window[index] and window.frames[index]. However,

Did you remove this comment because it's out-dated?

[Yuki, 2017-04-17 05:30:31]

yukishiino@chromium.org changed reviewers:
+ foolip@chromium.org, tkent@chromium.org

[Yuki, 2017-04-17 05:30:31]

+tkent@ and foolip@ as API_OWNERS.

Could you guys review this CL?

This CL changes a web-exposed behavior (more conformant to the spec).

https://codereview.chromium.org/2816743002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/DOMWindow.h (left):

https://codereview.chromium.org/2816743002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/DOMWindow.h:85: // FIXME: This handles both
window[index] and window.frames[index]. However,
On 2017/04/14 18:50:06, haraken wrote:
> 
> Did you remove this comment because it's out-dated?

Yes, the comment is out-dated and no longer correct.
|window| and |window.frames| are the same thing in the current spec.

[tkent, 2017-04-17 05:42:18]

This looks a minor bug fix.  LGTM.

[Yuki, 2017-04-17 08:03:51]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2017-04-17 08:04:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 09:28:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492416231075470,
"parent_rev": "782c68372ded66d885ebd848bace62d639998dfc", "commit_rev":
"c105f1574d48e229385fbef9293aca66fc087f9b"}

[commit-bot: I haz the power, 2017-04-17 09:29:04]

Description was changed from

==========
v8binding: Implements an alternative of WindowProxy.[[DefineOwnProperty]].

Implements the following part of the spec with using indexed interceptor.
https://html.spec.whatwg.org/C/browsers.html#windowproxy-defineownproperty
step 2 - 1. If P is an array index property name, return false.

The spec's actual effect is mostly that author script cannot define
a property with an array index property name on a window object.

With this CL, the following ES code has no effect.
  window[0] = 42;
  Object.defineProperty(window, 0, {value: 42});

BUG=695385
==========

to

==========
v8binding: Implements an alternative of WindowProxy.[[DefineOwnProperty]].

Implements the following part of the spec with using indexed interceptor.
https://html.spec.whatwg.org/C/browsers.html#windowproxy-defineownproperty
step 2 - 1. If P is an array index property name, return false.

The spec's actual effect is mostly that author script cannot define
a property with an array index property name on a window object.

With this CL, the following ES code has no effect.
  window[0] = 42;
  Object.defineProperty(window, 0, {value: 42});

BUG=695385

Review-Url: https://codereview.chromium.org/2816743002
Cr-Commit-Position: refs/heads/master@{#464912}
Committed:
https://chromium.googlesource.com/chromium/src/+/c105f1574d48e229385fbef9293a...
==========

[commit-bot: I haz the power, 2017-04-17 09:29:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c105f1574d48e229385fbef9293a...