Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: third_party/WebKit/Source/core/frame/Window.idl

Issue 2816743002: v8binding: Implements an alternative of WindowProxy.[[DefineOwnProperty]]. (Closed)
Patch Set: Fixed tests. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Window.idl
diff --git a/third_party/WebKit/Source/core/frame/Window.idl b/third_party/WebKit/Source/core/frame/Window.idl
index c86c8b21790ac6626c5f682a9df2207544a54917..2bbfaa865627a17625dfbc751ada0eb494480289 100644
--- a/third_party/WebKit/Source/core/frame/Window.idl
+++ b/third_party/WebKit/Source/core/frame/Window.idl
@@ -64,8 +64,14 @@
[CheckSecurity=ReturnValue, Custom=Getter] readonly attribute Element? frameElement;
// FIXME: open() should have 4 optional arguments with defaults.
[Custom] Window? open(DOMString url, DOMString target, optional DOMString features);
- // FIXME: These getters should not have [NotEnumerable].
+
+ // indexed properties
+ // https://html.spec.whatwg.org/C/browsers.html#windowproxy-getownproperty
[NotEnumerable, CrossOrigin] getter Window (unsigned long index);
+ // https://html.spec.whatwg.org/C/browsers.html#windowproxy-defineownproperty
+ setter void (unsigned long index, any value);
+
+ // named properties
[Custom, NotEnumerable, CrossOrigin] getter object (DOMString name);
// the user agent

Powered by Google App Engine
This is Rietveld 408576698