Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1690)

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.h

Issue 2816743002: v8binding: Implements an alternative of WindowProxy.[[DefineOwnProperty]]. (Closed)
Patch Set: Fixed tests. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/DOMWindow.h
diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.h b/third_party/WebKit/Source/core/frame/DOMWindow.h
index d7e3bc1062d41863beddac26fbcbd48f21dc39cc..877e1463b955cffd28726dd79d30bb7c5378969f 100644
--- a/third_party/WebKit/Source/core/frame/DOMWindow.h
+++ b/third_party/WebKit/Source/core/frame/DOMWindow.h
@@ -18,9 +18,10 @@ namespace blink {
class Document;
class InputDeviceCapabilitiesConstants;
-class Location;
class LocalDOMWindow;
+class Location;
class MessageEvent;
+class ScriptValue;
class SerializedScriptValue;
class CORE_EXPORT DOMWindow : public EventTargetWithInlineData,
@@ -82,10 +83,9 @@ class CORE_EXPORT DOMWindow : public EventTargetWithInlineData,
virtual void blur() = 0;
void close(ExecutionContext*);
- // FIXME: This handles both window[index] and window.frames[index]. However,
haraken 2017/04/14 18:50:06 Did you remove this comment because it's out-dated
Yuki 2017/04/17 05:30:31 Yes, the comment is out-dated and no longer correc
- // the spec exposes window.frames[index] across origins but not
- // window[index]...
- DOMWindow* AnonymousIndexedGetter(uint32_t) const;
+ // Indexed properties
+ DOMWindow* AnonymousIndexedGetter(uint32_t index) const;
+ bool AnonymousIndexedSetter(uint32_t index, const ScriptValue&);
void postMessage(PassRefPtr<SerializedScriptValue> message,
const MessagePortArray&,

Powered by Google App Engine
This is Rietveld 408576698