Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5103)

Unified Diff: chrome/browser/plugins/plugin_finder.cc

Issue 2816513002: Revert of Change base::Value::ListStorage to std::vector<base::Value> (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/plugin_finder.cc
diff --git a/chrome/browser/plugins/plugin_finder.cc b/chrome/browser/plugins/plugin_finder.cc
index 75c6ecab9a8d0d770141f7d3aaa6d18ddf249192..5ac803d22d08c981b0ba865c611c61e147188637 100644
--- a/chrome/browser/plugins/plugin_finder.cc
+++ b/chrome/browser/plugins/plugin_finder.cc
@@ -80,7 +80,7 @@
for (base::ListValue::const_iterator mime_type_it = mime_types->begin();
mime_type_it != mime_types->end(); ++mime_type_it) {
std::string mime_type_str;
- success = mime_type_it->GetAsString(&mime_type_str);
+ success = (*mime_type_it)->GetAsString(&mime_type_str);
DCHECK(success);
if (matching_mime_types) {
plugin->AddMatchingMimeType(mime_type_str);
@@ -115,8 +115,8 @@
if (plugin_dict->GetList("versions", &versions)) {
for (base::ListValue::const_iterator it = versions->begin();
it != versions->end(); ++it) {
- const base::DictionaryValue* version_dict = NULL;
- if (!it->GetAsDictionary(&version_dict)) {
+ base::DictionaryValue* version_dict = NULL;
+ if (!(*it)->GetAsDictionary(&version_dict)) {
NOTREACHED();
continue;
}
« no previous file with comments | « chrome/browser/permissions/chooser_context_base.cc ('k') | chrome/browser/plugins/plugin_finder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698