Remove non-const version of GetDefaultSearchProvider() and make all callers call the const version

Remove non-const version of GetDefaultSearchProvider() and make all callers call the const version

BUG=672364
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2816383002
Cr-Commit-Position: refs/heads/master@{#466554}
Committed: https://chromium.googlesource.com/chromium/src/+/8aa7a4e1cf5bb91918e8692a1909ededca93523b

[jeffschiller, 2017-04-16 20:28:41]

jeffschiller@google.com changed reviewers:
+ battre@chromium.org, kmadhusu@chromium.org, mmenke@chromium.org,
pkasting@chromium.org

[mmenke, 2017-04-17 03:35:44]

c/b/l LGTM

[jeffschiller, 2017-04-17 16:35:11]

The CQ bit was checked by jeffschiller@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 16:35:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 16:43:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 16:43:10]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[jeffschiller, 2017-04-17 16:56:57]

The CQ bit was checked by jeffschiller@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 16:57:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 17:06:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 17:06:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Peter Kasting, 2017-04-17 18:56:59]

LGTM, but looks like you still have a lot of callsites in test code that break
the compile

https://codereview.chromium.org/2816383002/diff/20001/ios/chrome/browser/goog...
File ios/chrome/browser/google/google_logo_service.mm (right):

https://codereview.chromium.org/2816383002/diff/20001/ios/chrome/browser/goog...
ios/chrome/browser/google/google_logo_service.mm:95: const TemplateURL*
template_url = template_url_service->GetDefaultSearchProvider();
Nit: 80 columns; git cl format can find this sort of thing automatically

[jeffschiller, 2017-04-17 19:07:26]

The CQ bit was checked by jeffschiller@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 19:07:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 19:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 19:19:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jeffschiller, 2017-04-17 20:55:00]

The CQ bit was checked by jeffschiller@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 20:55:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 21:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 21:41:20]

Dry run: This issue passed the CQ dry run.

[jeffschiller, 2017-04-18 01:48:25]

jeffschiller@google.com changed reviewers:
+ jam@chromium.org, jochen@chromium.org
- battre@chromium.org, kmadhusu@chromium.org

[Peter Kasting, 2017-04-18 02:07:32]

LGTM

(1) When adding multiple reviewers, say exactly what you want each to review.
(2) When changes to an area are purely mechanical like this, it's OK to TBR the
OWNERS for that area so you're not blocked on trivial approvals.

https://codereview.chromium.org/2816383002/diff/60001/chrome/browser/search_e...
File chrome/browser/search_engines/template_url_service_unittest.cc (right):

https://codereview.chromium.org/2816383002/diff/60001/chrome/browser/search_e...
chrome/browser/search_engines/template_url_service_unittest.cc:1404:
const_cast<TemplateURL*>(model()->GetDefaultSearchProvider());
Avoid this cast... for example:

  // Force the model to load and make sure we have a default search provider.
  test_util()->VerifyLoad();
  const TemplateURL* default_search = model()->GetDefaultSearchProvider();
  EXPECT_TRUE(default_search);
  EXPECT_TRUE(default_search->SupportsReplacement(search_terms_data()));

  // Make default search provider unusable (no search terms).  Using
  // GetTemplateURLForKeyword() gets a non-const pointer.
  model()->ResetTemplateURL(
      model()->GetTemplateURLForKeyword(default_search->keyword()),
      ASCIIToUTF16("test"), ASCIIToUTF16("test"), "http://example.com/");

[jeffschiller, 2017-04-18 04:49:54]

The CQ bit was checked by jeffschiller@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 04:50:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 05:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 05:14:03]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[battre, 2017-04-18 09:13:21]

battre@chromium.org changed reviewers:
+ battre@chromium.org

[battre, 2017-04-18 09:13:22]

mechanical changes in chrome/browser/profile_resetter LGTM

[jochen (gone - plz use gerrit), 2017-04-18 11:39:08]

lgtm

[jeffschiller, 2017-04-21 03:48:17]

The CQ bit was checked by jeffschiller@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 03:48:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 04:35:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 04:35:56]

Dry run: This issue passed the CQ dry run.

[jeffschiller, 2017-04-21 04:58:36]

jam, please review mechanical changes in:
  chrome/browser/android/contextualsearch/contextual_search_delegate.cc
  chrome/browser/android/locale/special_locale_handler.cc
  chrome/browser/android/logo_service.cc
 
chrome/browser/extensions/api/settings_overrides/settings_overrides_browsertest.cc
  chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
  chrome/browser/policy/policy_browsertest.cc
  chrome/browser/profile_resetter/profile_resetter_unittest.cc
  chrome/browser/profile_resetter/resettable_settings_snapshot.cc
  chrome/browser/search/search.cc
  chrome/browser/search_engines/template_url_service_android.cc
  chrome/browser/search_engines/template_url_service_sync_unittest.cc
  chrome/browser/search_engines/template_url_service_unittest.cc
  chrome/browser/ui/search/instant_extended_interactive_uitest.cc
  chrome/browser/ui/search_engines/keyword_editor_controller.cc
  chrome/browser/ui/search_engines/keyword_editor_controller.h
  components/omnibox/browser/history_url_provider.cc
  components/omnibox/browser/history_url_provider.h
  components/search_engines/template_url.cc
  components/search_engines/template_url.h
  components/search_engines/template_url_service.cc
  components/search_engines/template_url_service.h
  ios/chrome/browser/google/google_logo_service.mm
  ios/chrome/browser/ui/browser_view_controller.mm
  ios/chrome/browser/ui/contextual_search/contextual_search_delegate.cc
 
ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.mm
  ios/chrome/browser/ui/ntp/google_landing_controller.mm
  ios/chrome/browser/ui/ntp/new_tab_page_controller.mm

https://codereview.chromium.org/2816383002/diff/60001/chrome/browser/search_e...
File chrome/browser/search_engines/template_url_service_unittest.cc (right):

https://codereview.chromium.org/2816383002/diff/60001/chrome/browser/search_e...
chrome/browser/search_engines/template_url_service_unittest.cc:1404:
const_cast<TemplateURL*>(model()->GetDefaultSearchProvider());
On 2017/04/18 at 02:07:32, Peter Kasting wrote:
> Avoid this cast... for example:
> 
>   // Force the model to load and make sure we have a default search provider.
>   test_util()->VerifyLoad();
>   const TemplateURL* default_search = model()->GetDefaultSearchProvider();
>   EXPECT_TRUE(default_search);
>   EXPECT_TRUE(default_search->SupportsReplacement(search_terms_data()));
> 
>   // Make default search provider unusable (no search terms).  Using
>   // GetTemplateURLForKeyword() gets a non-const pointer.
>   model()->ResetTemplateURL(
>       model()->GetTemplateURLForKeyword(default_search->keyword()),
>       ASCIIToUTF16("test"), ASCIIToUTF16("test"), "http://example.com/");

Done.

https://codereview.chromium.org/2816383002/diff/60001/chrome/browser/search_e...
chrome/browser/search_engines/template_url_service_unittest.cc:1404:
const_cast<TemplateURL*>(model()->GetDefaultSearchProvider());
On 2017/04/18 at 02:07:32, Peter Kasting wrote:
> Avoid this cast... for example:
> 
>   // Force the model to load and make sure we have a default search provider.
>   test_util()->VerifyLoad();
>   const TemplateURL* default_search = model()->GetDefaultSearchProvider();
>   EXPECT_TRUE(default_search);
>   EXPECT_TRUE(default_search->SupportsReplacement(search_terms_data()));
> 
>   // Make default search provider unusable (no search terms).  Using
>   // GetTemplateURLForKeyword() gets a non-const pointer.
>   model()->ResetTemplateURL(
>       model()->GetTemplateURLForKeyword(default_search->keyword()),
>       ASCIIToUTF16("test"), ASCIIToUTF16("test"), "http://example.com/");

Done.

[jeffschiller, 2017-04-22 15:20:54]

Description was changed from

==========
Remove non-const version of GetDefaultSearchProvider() and make all callers call
the const version

BUG=672364
==========

to

==========
Remove non-const version of GetDefaultSearchProvider() and make all callers call
the const version

BUG=672364

TBR=jam@chromium.org
==========

[jeffschiller, 2017-04-22 15:39:13]

The CQ bit was checked by jeffschiller@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-22 15:39:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 16:22:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 16:22:57]

Dry run: This issue passed the CQ dry run.

[jeffschiller, 2017-04-23 02:18:08]

The CQ bit was checked by jeffschiller@google.com

[jeffschiller, 2017-04-23 02:18:09]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org,
pkasting@chromium.org, jochen@chromium.org, battre@chromium.org
Link to the patchset: https://codereview.chromium.org/2816383002/#ps120001
(title: "Fix unit test (the model was already loaded)")

[commit-bot: I haz the power, 2017-04-23 02:18:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-23 02:22:13]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1492913888616270,
"parent_rev": "a9e14964b037e70a90936908b8740d50b73e3b73", "commit_rev":
"8aa7a4e1cf5bb91918e8692a1909ededca93523b"}

[commit-bot: I haz the power, 2017-04-23 02:23:42]

Description was changed from

==========
Remove non-const version of GetDefaultSearchProvider() and make all callers call
the const version

BUG=672364

TBR=jam@chromium.org
==========

to

==========
Remove non-const version of GetDefaultSearchProvider() and make all callers call
the const version

BUG=672364

TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2816383002
Cr-Commit-Position: refs/heads/master@{#466554}
Committed:
https://chromium.googlesource.com/chromium/src/+/8aa7a4e1cf5bb91918e8692a1909...
==========

[commit-bot: I haz the power, 2017-04-23 02:23:43]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/8aa7a4e1cf5bb91918e8692a1909...