ios/chrome/browser/google/google_logo_service.mm - Issue 2816383002: Remove non-const version of GetDefaultSearchProvider() and make all callers call the const version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/google/google_logo_service.mm

Issue 2816383002: Remove non-const version of GetDefaultSearchProvider() and make all callers call the const version (Closed)

Patch Set: Fix unit test (the model was already loaded) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/google/google_logo_service.mm

diff --git a/ios/chrome/browser/google/google_logo_service.mm b/ios/chrome/browser/google/google_logo_service.mm

index b646df95c36f52f80429a34ea6b3742c59b14e08..c4cf895362dadea456231ba24ae29c45a2bbbd44 100644

--- a/ios/chrome/browser/google/google_logo_service.mm

+++ b/ios/chrome/browser/google/google_logo_service.mm

@@ -92,7 +92,8 @@ void GoogleLogoService::GetLogo(search_provider_logos::LogoObserver* observer) {

if (!template_url_service)

return;

- TemplateURL* template_url = template_url_service->GetDefaultSearchProvider();

+ const TemplateURL* template_url =

+ template_url_service->GetDefaultSearchProvider();

if (!template_url ||

!template_url->url_ref().HasGoogleBaseURLs(

template_url_service->search_terms_data()))