components/search_engines/template_url_service.h - Issue 2816383002: Remove non-const version of GetDefaultSearchProvider() and make all callers call the const version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/template_url_service.h

Issue 2816383002: Remove non-const version of GetDefaultSearchProvider() and make all callers call the const version (Closed)

Patch Set: Fix unit test (the model was already loaded) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/search_engines/template_url_service.h

diff --git a/components/search_engines/template_url_service.h b/components/search_engines/template_url_service.h

index 7698f8fd7f4f6dfb4b1a75f3efe2f29c8aa5f220..058b0a0d50bc6ae0df017d0588175712514ce0d3 100644

--- a/components/search_engines/template_url_service.h

+++ b/components/search_engines/template_url_service.h

@@ -258,9 +258,6 @@ class TemplateURLService : public WebDataServiceConsumer,

// loaded, the default search provider is pulled from preferences.

// NOTE: At least in unittest mode, this may return NULL.

- // TODO(blundell): See if all callers can be converted to take in const

- // pointers and eliminate this version of the method.

- TemplateURL* GetDefaultSearchProvider();

const TemplateURL* GetDefaultSearchProvider() const;

// Returns true if the |url| is a search results page from the default search