Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2816103002: [Media] Access bg video finch trial params directly from the renderer (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/web_preferences.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index a978544ea1a23cd37bb31c17139ab041c050053e..3d0566c37d5de42f838c0fc3ca1912ad29472a0d 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -24,6 +24,7 @@
#include "base/memory/shared_memory.h"
#include "base/memory/weak_ptr.h"
#include "base/metrics/field_trial.h"
+#include "base/metrics/field_trial_params.h"
#include "base/metrics/histogram_macros.h"
#include "base/process/process.h"
#include "base/stl_util.h"
@@ -2875,6 +2876,11 @@ blink::WebMediaPlayer* RenderFrameImpl::CreateMediaPlayer(
base::WeakPtr<media::MediaObserver> media_observer = nullptr;
#endif
+ base::TimeDelta max_keyframe_distance_to_disable_background_video =
+ base::TimeDelta::FromMilliseconds(base::GetFieldTrialParamByFeatureAsInt(
+ media::kBackgroundVideoTrackOptimization, "max_keyframe_distance_ms",
+ base::TimeDelta::FromSeconds(10).InMilliseconds()));
+
media::WebMediaPlayerParams params(
base::Bind(&ContentRendererClient::DeferMediaLoad,
base::Unretained(GetContentClient()->renderer()),
@@ -2887,9 +2893,7 @@ blink::WebMediaPlayer* RenderFrameImpl::CreateMediaPlayer(
base::Bind(&v8::Isolate::AdjustAmountOfExternalAllocatedMemory,
base::Unretained(blink::MainThreadIsolate())),
initial_cdm, media_surface_manager_, media_observer,
- // TODO(avayvod, asvitkine): Query the value directly when it is available
- // in the renderer process. See https://crbug.com/681160.
- GetWebkitPreferences().max_keyframe_distance_to_disable_background_video,
+ max_keyframe_distance_to_disable_background_video,
GetWebkitPreferences().enable_instant_source_buffer_gc,
GetContentClient()->renderer()->AllowMediaSuspend(),
embedded_media_experience_enabled);
« no previous file with comments | « content/public/common/web_preferences.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698