Rename Script() returning UScriptCode to GetScript()

Rename Script() returning UScriptCode to GetScript()

To avoid naming conflict between Script() and a new class Script that will
be introduced by https://codereview.chromium.org/2780463002/.

BUG=686281
Review-Url: https://codereview.chromium.org/2815523002
Cr-Commit-Position: refs/heads/master@{#464064}
Committed: https://chromium.googlesource.com/chromium/src/+/c6494e265fc1de5c751198a4282daf7e5c30eb10

[hiroshige, 2017-04-11 00:42:12]

Description was changed from

==========
Rename Script() returning UScriptCode to GetScript()

To avoid naming conflict between Script() and a new class Script that will
be introduced by https://codereview.chromium.org/2780463002/.

BUG=686281
==========

to

==========
Rename Script() returning UScriptCode to GetScript()

To avoid naming conflict between Script() and a new class Script that will
be introduced by https://codereview.chromium.org/2780463002/.

BUG=686281
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[hiroshige, 2017-04-11 00:42:13]

Description was changed from

==========
Rename Script() returning UScriptCode to GetScript()

To avoid naming conflict between Script() and a new class Script that will
be introduced by https://codereview.chromium.org/2780463002/.

BUG=686281
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Rename Script() returning UScriptCode to GetScript()

To avoid naming conflict between Script() and a new class Script that will
be introduced by https://codereview.chromium.org/2780463002/.

BUG=686281
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[hiroshige, 2017-04-11 00:42:15]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 00:42:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-11 00:47:26]

hiroshige@chromium.org changed reviewers:
+ kinuko@chromium.org, kojii@chromium.org

[hiroshige, 2017-04-11 00:47:27]

PTAL.

https://codereview.chromium.org/2815523002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/LayoutLocale.h (right):

https://codereview.chromium.org/2815523002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/LayoutLocale.h:54: UScriptCode
GetScriptForHan() const;
Renamed for consistency with GetScript().

[hiroshige, 2017-04-11 00:52:09]

hiroshige@chromium.org changed reviewers:
+ japhet@chromium.org, kouhei@chromium.org

[kouhei (in TOK), 2017-04-11 00:53:15]

lgtm

[commit-bot: I haz the power, 2017-04-11 01:21:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 01:21:38]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[kinuko, 2017-04-11 01:34:29]

lgtm (once you fix build)

[kojii, 2017-04-11 01:41:59]

lgtm

[hiroshige, 2017-04-11 16:32:18]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 16:33:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 16:37:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 16:37:29]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2017-04-11 17:35:56]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 17:36:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-11 17:54:03]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2017-04-11 17:54:07]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2017-04-11 17:54:08]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
kojii@chromium.org, kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2815523002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-11 17:54:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 20:01:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 20:01:41]

Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[hiroshige, 2017-04-12 16:06:16]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2017-04-12 16:06:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 16:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 16:50:54]

Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[hiroshige, 2017-04-12 16:58:47]

Description was changed from

==========
Rename Script() returning UScriptCode to GetScript()

To avoid naming conflict between Script() and a new class Script that will
be introduced by https://codereview.chromium.org/2780463002/.

BUG=686281
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Rename Script() returning UScriptCode to GetScript()

To avoid naming conflict between Script() and a new class Script that will
be introduced by https://codereview.chromium.org/2780463002/.

BUG=686281
==========

[hiroshige, 2017-04-12 16:58:56]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2017-04-12 16:59:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:24:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492016336640910,
"parent_rev": "c3af64f7f18be7630bdec9e879a2eb457464c591", "commit_rev":
"c6494e265fc1de5c751198a4282daf7e5c30eb10"}

[commit-bot: I haz the power, 2017-04-12 17:25:24]

Description was changed from

==========
Rename Script() returning UScriptCode to GetScript()

To avoid naming conflict between Script() and a new class Script that will
be introduced by https://codereview.chromium.org/2780463002/.

BUG=686281
==========

to

==========
Rename Script() returning UScriptCode to GetScript()

To avoid naming conflict between Script() and a new class Script that will
be introduced by https://codereview.chromium.org/2780463002/.

BUG=686281

Review-Url: https://codereview.chromium.org/2815523002
Cr-Commit-Position: refs/heads/master@{#464064}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6494e265fc1de5c751198a4282d...
==========

[commit-bot: I haz the power, 2017-04-12 17:25:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c6494e265fc1de5c751198a4282d...