third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp - Issue 2815523002: Rename Script() returning UScriptCode to GetScript()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

Issue 2815523002: Rename Script() returning UScriptCode to GetScript() (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

index 0088d5eb58cdf141e779212fee24f151eef3f32f..4bd5b541abc261429bb6d3263be0faec634122ca 100644

--- a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp

@@ -63,7 +63,7 @@ static ResolvedUnderlinePosition ResolveUnderlinePosition(

case kIdeographicBaseline:

// Compute language-appropriate default underline position.

// https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

- UScriptCode script = style.GetFontDescription().Script();

+ UScriptCode script = style.GetFontDescription().GetScript();

if (script == USCRIPT_KATAKANA_OR_HIRAGANA || script == USCRIPT_HANGUL)

return ResolvedUnderlinePosition::kOver;

return ResolvedUnderlinePosition::kUnder;