Don't double-prompt for uses of facetime:// and tel:// URLs.

Don't double-prompt for uses of facetime:// and tel:// URLs.

On iOS 10.3.2 (beta), the system is issuing confirmation prompts when
facetime:// or facetime-audio:// URLs are opened. This makes the
prompt generated by Chrome redundant and annoying to users of 10.3.2.

This CL checks for iOS version and prompts only when necessary.
Also removed the use of telprompt:// which may not be acceptable under
some interpretations.

BUG=710446
TEST=Please verify on the major supported versions of iOS, i.e. 9.x, 10.3, and the new 10.3.2 beta.

Review-Url: https://codereview.chromium.org/2815403003
Cr-Commit-Position: refs/heads/master@{#464639}
Committed: https://chromium.googlesource.com/chromium/src/+/fcfe426cf8f209b41779a43fca011a8c33c9176d

[pkl (ping after 24h if needed), 2017-04-13 22:05:05]

pkl@chromium.org changed reviewers:
+ cmasso@chromium.org, eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-04-13 22:47:30]

lgtm

https://codereview.chromium.org/2815403003/diff/1/ios/chrome/browser/web/exte...
File ios/chrome/browser/web/external_app_launcher.mm (right):

https://codereview.chromium.org/2815403003/diff/1/ios/chrome/browser/web/exte...
ios/chrome/browser/web/external_app_launcher.mm:57: -
(void)openPromptForURL:(NSURL*)telURL;
s/telURL/URL ?

https://codereview.chromium.org/2815403003/diff/1/ios/chrome/browser/web/exte...
ios/chrome/browser/web/external_app_launcher.mm:101: NSString* openTitle =
[URL.scheme isEqualToString:@"facetime"]
Do you want to DCHECK that URL.scheme is ether facetime, tel or facetime-audio?

https://codereview.chromium.org/2815403003/diff/1/ios/chrome/browser/web/exte...
ios/chrome/browser/web/external_app_launcher.mm:146: (gURL.SchemeIs("tel") ||
gURL.SchemeIs("facetime") ||
Do you want to create constants for these custom url schemes?

[pkl (ping after 24h if needed), 2017-04-14 00:34:51]

Thank you!

https://codereview.chromium.org/2815403003/diff/1/ios/chrome/browser/web/exte...
File ios/chrome/browser/web/external_app_launcher.mm (right):

https://codereview.chromium.org/2815403003/diff/1/ios/chrome/browser/web/exte...
ios/chrome/browser/web/external_app_launcher.mm:57: -
(void)openPromptForURL:(NSURL*)telURL;
On 2017/04/13 22:47:30, Eugene But wrote:
> s/telURL/URL ?

Done.

https://codereview.chromium.org/2815403003/diff/1/ios/chrome/browser/web/exte...
ios/chrome/browser/web/external_app_launcher.mm:101: NSString* openTitle =
[URL.scheme isEqualToString:@"facetime"]
On 2017/04/13 22:47:30, Eugene But wrote:
> Do you want to DCHECK that URL.scheme is ether facetime, tel or
facetime-audio?

Refactored into a anonymous function and do the NOTREACHED() there.

https://codereview.chromium.org/2815403003/diff/1/ios/chrome/browser/web/exte...
ios/chrome/browser/web/external_app_launcher.mm:146: (gURL.SchemeIs("tel") ||
gURL.SchemeIs("facetime") ||
On 2017/04/13 22:47:30, Eugene But wrote:
> Do you want to create constants for these custom url schemes?

Refactored so all the strings are nearby to not clutter the logic here. I find
consts for these common strings don't always improve readability.

[pkl (ping after 24h if needed), 2017-04-14 00:37:35]

The CQ bit was checked by pkl@chromium.org

[pkl (ping after 24h if needed), 2017-04-14 00:37:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2815403003/#ps40001
(title: "fixed typo")

[commit-bot: I haz the power, 2017-04-14 00:38:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 01:04:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492130255114920,
"parent_rev": "e60200b1f40dd1cd08ea573207bf2f4124665beb", "commit_rev":
"fcfe426cf8f209b41779a43fca011a8c33c9176d"}

[commit-bot: I haz the power, 2017-04-14 01:05:17]

Description was changed from

==========
Don't double-prompt for uses of facetime:// and tel:// URLs.

On iOS 10.3.2 (beta), the system is issuing confirmation prompts when
facetime:// or facetime-audio:// URLs are opened. This makes the
prompt generated by Chrome redundant and annoying to users of 10.3.2.

This CL checks for iOS version and prompts only when necessary.
Also removed the use of telprompt:// which may not be acceptable under
some interpretations.

BUG=710446
TEST=Please verify on the major supported versions of iOS, i.e. 9.x, 10.3, and
the new 10.3.2 beta.
==========

to

==========
Don't double-prompt for uses of facetime:// and tel:// URLs.

On iOS 10.3.2 (beta), the system is issuing confirmation prompts when
facetime:// or facetime-audio:// URLs are opened. This makes the
prompt generated by Chrome redundant and annoying to users of 10.3.2.

This CL checks for iOS version and prompts only when necessary.
Also removed the use of telprompt:// which may not be acceptable under
some interpretations.

BUG=710446
TEST=Please verify on the major supported versions of iOS, i.e. 9.x, 10.3, and
the new 10.3.2 beta.

Review-Url: https://codereview.chromium.org/2815403003
Cr-Commit-Position: refs/heads/master@{#464639}
Committed:
https://chromium.googlesource.com/chromium/src/+/fcfe426cf8f209b41779a43fca01...
==========

[commit-bot: I haz the power, 2017-04-14 01:05:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fcfe426cf8f209b41779a43fca01...