Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2814363003: Adds string for a prompt action button before making a phone call (Closed)

Created:
3 years, 8 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, srahim+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds string for a prompt action button before making a phone call When tel:// is process, prompt user for permission. This is a string addition only. Code change to come in the next CL. BUG=710446 Review-Url: https://codereview.chromium.org/2814363003 Cr-Commit-Position: refs/heads/master@{#464597} Committed: https://chromium.googlesource.com/chromium/src/+/04fd4a9cb77d7952d20236c2b57f8e4467e6ca7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
pkl (ping after 24h if needed)
String addition only.
3 years, 8 months ago (2017-04-13 21:56:58 UTC) #2
cmasso1
lgtm
3 years, 8 months ago (2017-04-13 22:03:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814363003/1
3 years, 8 months ago (2017-04-13 22:07:45 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-13 22:07:47 UTC) #8
pkl (ping after 24h if needed)
+eugenebut for committer
3 years, 8 months ago (2017-04-13 22:08:59 UTC) #10
Eugene But (OOO till 7-30)
This will also be used for facetime-audio, right? lgtm
3 years, 8 months ago (2017-04-13 22:51:27 UTC) #11
pkl (ping after 24h if needed)
On 2017/04/13 22:51:27, Eugene But wrote: > This will also be used for facetime-audio, right? ...
3 years, 8 months ago (2017-04-13 22:57:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814363003/1
3 years, 8 months ago (2017-04-13 22:58:55 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 23:13:19 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/04fd4a9cb77d7952d20236c2b57f...

Powered by Google App Engine
This is Rietveld 408576698