Don't double-prompt for uses of facetime:// and tel:// URLs.

ios/chrome/browser/web/external_app_launcher.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/web/external_app_launcher.h"
 
+#include "base/ios/ios_util.h"
 #include "base/ios/weak_nsobject.h"
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/sys_string_conversions.h"
 #include "components/strings/grit/components_strings.h"
 #include "ios/chrome/browser/experimental_flags.h"
 #import "ios/chrome/browser/open_url_util.h"
 #include "ios/chrome/grit/ios_strings.h"
 #import "net/base/mac/url_conversions.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 28 matching lines @@
 // opening, pass false.
 void RecordExternalApplicationOpened(bool opened) {
   UMA_HISTOGRAM_BOOLEAN("Tab.ExternalApplicationOpened", opened);
 }
 
 }  // namespace
 
 @interface ExternalAppLauncher ()
 // Returns the Phone/FaceTime call argument from |URL|.
 + (NSString*)formatCallArgument:(NSURL*)URL;
-// Ask user for confirmation before dialing FaceTime destination.
-- (void)openFaceTimePromptForURL:(NSURL*)telURL;
+// Ask user for confirmation before dialing Phone or FaceTime destinations.
+- (void)openPromptForURL:(NSURL*)telURL;

[Eugene But (OOO till 7-30), 2017/04/13 22:47:30]

s/telURL/URL ?

[pkl (ping after 24h if needed), 2017/04/14 00:34:50]

Done.

 // Ask user for confirmation before moving to external app.
 - (void)openExternalAppWithPromptForURL:(NSURL*)URL;
 // Presents a configured alert controller on the root view controller.
 - (void)presentAlertControllerWithMessage:(NSString*)message
                                 openTitle:(NSString*)openTitle
                               openHandler:(AlertHandler)openHandler
                             cancelHandler:(AlertHandler)cancelHandler;
 @end
 
 @implementation ExternalAppLauncher
@@ skipping 22 matching lines @@
       openTitle:openTitle
       openHandler:^(UIAlertAction* action) {
         RecordExternalApplicationOpened(true);
         OpenUrlWithCompletionHandler(URL, nil);
       }
       cancelHandler:^(UIAlertAction* action) {
         RecordExternalApplicationOpened(false);
       }];
 }
 
-- (void)openFaceTimePromptForURL:(NSURL*)URL {
-  NSString* openTitle = l10n_util::GetNSString(IDS_IOS_FACETIME_BUTTON);
+- (void)openPromptForURL:(NSURL*)URL {
+  NSString* openTitle = [URL.scheme isEqualToString:@"facetime"]

[Eugene But (OOO till 7-30), 2017/04/13 22:47:30]

Do you want to DCHECK that URL.scheme is ether facetime, tel or facetime-audio?

[pkl (ping after 24h if needed), 2017/04/14 00:34:50]

Refactored into a anonymous function and do the NOTREACHED() there.

+                            ? l10n_util::GetNSString(IDS_IOS_FACETIME_BUTTON)
+                            : l10n_util::GetNSString(IDS_IOS_PHONE_CALL_BUTTON);
   [self presentAlertControllerWithMessage:[[self class] formatCallArgument:URL]
                                 openTitle:openTitle
                               openHandler:^(UIAlertAction* action) {
                                 OpenUrlWithCompletionHandler(URL, nil);
                               }
                             cancelHandler:nil];
 }
 
 - (void)presentAlertControllerWithMessage:(NSString*)message
                                 openTitle:(NSString*)openTitle
@@ skipping 18 matching lines @@
       presentViewController:alertController
                    animated:YES
                  completion:nil];
 }
 
 - (BOOL)openURL:(const GURL&)gURL linkClicked:(BOOL)linkClicked {
   if (!gURL.is_valid() || !gURL.has_scheme())
     return NO;
   NSURL* URL = net::NSURLWithGURL(gURL);
 
-  if (gURL.SchemeIs("facetime") || gURL.SchemeIs("facetime-audio")) {
+  // iOS 10.3.2 introduced new prompts when facetime: and facetime-audio:
+  // URL schemes are opened. It is no longer necessary for Chrome to present
+  // another prompt before the system-provided prompt.
+  if (!base::ios::IsRunningOnOrLater(10, 3, 2) &&
+      (gURL.SchemeIs("tel") || gURL.SchemeIs("facetime") ||

[Eugene But (OOO till 7-30), 2017/04/13 22:47:30]

Do you want to create constants for these custom url schemes?

[pkl (ping after 24h if needed), 2017/04/14 00:34:50]

Refactored so all the strings are nearby to not clutter the logic here. I find
consts for these common strings don't always improve readability.

+       gURL.SchemeIs("facetime-audio"))) {
     // Showing an alert view immediately has a side-effect where focus is
     // taken from the UIWebView so quickly that mouseup events are lost and
     // buttons get 'stuck' in the on position. The solution is to defer
     // showing the view.
-    [self performSelector:@selector(openFaceTimePromptForURL:)
+    [self performSelector:@selector(openPromptForURL:)
                withObject:URL
                afterDelay:0.0];
     return YES;
   }
 
-  // Use telprompt instead of tel because telprompt returns user back to
-  // Chrome after phone call is completed/aborted.
-  if (gURL.SchemeIs("tel")) {
-    GURL::Replacements replacements;
-    replacements.SetSchemeStr("telprompt");
-    URL = net::NSURLWithGURL(gURL.ReplaceComponents(replacements));
-    DCHECK([[URL scheme] isEqualToString:@"telprompt"]);
-  }
-
   // Don't open external application if chrome is not active.
   if ([[UIApplication sharedApplication] applicationState] !=
       UIApplicationStateActive)
     return NO;
 
   if (experimental_flags::IsExternalApplicationPromptEnabled()) {
     // Prompt user to open itunes when opening it is not a result of a link
     // click.
     if (!linkClicked && UrlHasAppStoreScheme(gURL)) {
       [self performSelector:@selector(openExternalAppWithPromptForURL:)
                  withObject:URL
                  afterDelay:0.0];
       return YES;
     }
   }
 
   // If the following call returns YES, an external application is about to be
   // launched and Chrome will go into the background now.
   // TODO(crbug.com/622735): This call still needs to be updated.
   // It's heavily nested so some refactoring is needed.
   return [[UIApplication sharedApplication] openURL:URL];
 }
 
 @end