Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2815313002: Reland of Move ScriptState::GetExecutionContext (Part 5) (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 8 months ago
Reviewers:
haraken, jbroman, adithyas
CC:
ajuma+watch-canvas_chromium.org, awdf+watch_chromium.org, blink-reviews, Rik, chromium-reviews, cmumford, dominickn+watch_chromium.org, dshwang, eric.carlson_apple.com, falken+watch_chromium.org, feature-media-reviews_chromium.org, feature-vr-reviews_chromium.org, harkness+watch_chromium.org, hongchan, horo+watch_chromium.org, jkarlin+watch_chromium.org, johnme+watch_chromium.org, jsbell+serviceworker_chromium.org, jsbell+idb_chromium.org, Justin Novosad, kinuko+fileapi, kinuko+serviceworker, michaeln, mlamouri+watch-blink_chromium.org, nhiroki, ortuno+watch_chromium.org, Peter Beverloo, pkotwicz+watch_chromium.org, Raymond Toy, scheib+watch_chromium.org, serviceworker-reviews, shimazu+serviceworker_chromium.org, Srirama, timvolodine, tommyw+watchlist_chromium.org, toyoshim+midi_chromium.org, tzik, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Move ScriptState::GetExecutionContext (Part 5) (patchset #2 id:300001 of https://codereview.chromium.org/2821443002/ ) Reason for revert: Broke Build Original issue's description: > Revert of Move ScriptState::GetExecutionContext (Part 5) (patchset #3 id:40001 of https://codereview.chromium.org/2816543002/ ) > > Reason for revert: > Suspected culprit of webkit_tests failing on chromium.webkit/WebKit Linux Trusty MSAN. > > BUG=711250 > > Original issue's description: > > Move ScriptState::GetExecutionContext (Part 5) > > > > This CL replaces all uses of ScriptState::GetExecutionContext in Source/modules with ExecutionContext::From. > > > > BUG=682322 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > > > Review-Url: https://codereview.chromium.org/2816543002 > > Cr-Commit-Position: refs/heads/master@{#464056} > > Committed: https://chromium.googlesource.com/chromium/src/+/d2d9a34e2fd74fd45026a8fed6f4715de18df747 > > TBR=jbroman@chromium.org,haraken@chromium.org,adithyas@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=682322 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > TBR=jbroman@chromium.org,haraken@chromium.org,adithyas@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=711250 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2815313002 Cr-Commit-Position: refs/heads/master@{#464376} Committed: https://chromium.googlesource.com/chromium/src/+/e87bbc88306d3bbac6249887d846077c8d0f923b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -232 lines) Patch
M third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryManager.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/NavigatorBattery.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/budget/BudgetService.cpp View 6 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp View 8 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/crypto/SubtleCrypto.cpp View 13 chunks +23 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Body.cpp View 5 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.cpp View 7 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 7 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/ResponseTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/Entry.cpp View 8 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/filesystem/HTMLInputElementFileSystem.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp View 11 chunks +20 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBIndex.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBKeyRange.cpp View 7 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaMetadata.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/URLMediaSource.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/netinfo/WorkerNavigatorNetworkInformation.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 14 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/permissions/Permissions.cpp View 9 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationReceiver.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushManager.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageManager.cpp View 8 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/InstallEvent.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp View 5 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/DOMWindowSpeechSynthesis.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechGrammar.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechGrammarList.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 5 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jdoerrie
Created Reland of Move ScriptState::GetExecutionContext (Part 5)
3 years, 8 months ago (2017-04-13 11:40:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815313002/1
3 years, 8 months ago (2017-04-13 11:40:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815313002/1
3 years, 8 months ago (2017-04-13 11:46:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e87bbc88306d3bbac6249887d846077c8d0f923b
3 years, 8 months ago (2017-04-13 11:49:22 UTC) #10
haraken
3 years, 8 months ago (2017-04-13 12:35:09 UTC) #11
Message was sent while issue was closed.
LGTM. Yeah, this CL shouldn't be related.

Powered by Google App Engine
This is Rietveld 408576698