Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

Issue 2815313002: Reland of Move ScriptState::GetExecutionContext (Part 5) (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
diff --git a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
index 209a51e4e3aee73a6072a34152afc97d7e0891e0..684815b852c397677a3468274a4d7898d8735306 100644
--- a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
+++ b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
@@ -65,7 +65,7 @@
void OnSuccess() override {
Frame* frame =
- ToDocument(resolver_->GetScriptState()->GetExecutionContext())
+ ToDocument(ExecutionContext::From(resolver_->GetScriptState()))
->GetFrame();
SECURITY_CHECK(!frame || frame == frame->Tree().Top());
@@ -90,7 +90,7 @@
void OnSuccess(std::unique_ptr<WebCredential> web_credential) override {
Frame* frame =
- ToDocument(resolver_->GetScriptState()->GetExecutionContext())
+ ToDocument(ExecutionContext::From(resolver_->GetScriptState()))
->GetFrame();
SECURITY_CHECK(!frame || frame == frame->Tree().Top());
@@ -103,7 +103,7 @@
ASSERT(credential->IsPasswordCredential() ||
credential->IsFederatedCredential());
- UseCounter::Count(resolver_->GetScriptState()->GetExecutionContext(),
+ UseCounter::Count(ExecutionContext::From(resolver_->GetScriptState()),
UseCounter::kCredentialManagerGetReturnedCredential);
if (credential->IsPasswordCredential())
resolver_->Resolve(PasswordCredential::Create(
@@ -128,8 +128,8 @@
CredentialsContainer::CredentialsContainer() {}
static bool CheckBoilerplate(ScriptPromiseResolver* resolver) {
- Frame* frame =
- ToDocument(resolver->GetScriptState()->GetExecutionContext())->GetFrame();
+ Frame* frame = ToDocument(ExecutionContext::From(resolver->GetScriptState()))
+ ->GetFrame();
if (!frame || frame != frame->Tree().Top()) {
resolver->Reject(DOMException::Create(kSecurityError,
"CredentialContainer methods may "
@@ -139,14 +139,14 @@
}
String error_message;
- if (!resolver->GetScriptState()->GetExecutionContext()->IsSecureContext(
- error_message)) {
+ if (!ExecutionContext::From(resolver->GetScriptState())
+ ->IsSecureContext(error_message)) {
resolver->Reject(DOMException::Create(kSecurityError, error_message));
return false;
}
CredentialManagerClient* client = CredentialManagerClient::From(
- resolver->GetScriptState()->GetExecutionContext());
+ ExecutionContext::From(resolver->GetScriptState()));
if (!client) {
resolver->Reject(DOMException::Create(
kInvalidStateError,
@@ -181,12 +181,12 @@
}
}
- UseCounter::Count(script_state->GetExecutionContext(),
+ UseCounter::Count(ExecutionContext::From(script_state),
options.unmediated()
? UseCounter::kCredentialManagerGetWithoutUI
: UseCounter::kCredentialManagerGetWithUI);
- CredentialManagerClient::From(script_state->GetExecutionContext())
+ CredentialManagerClient::From(ExecutionContext::From(script_state))
->DispatchGet(options.unmediated(), options.password(), providers,
new RequestCallbacks(resolver));
return promise;
@@ -201,7 +201,7 @@
auto web_credential =
WebCredential::Create(credential->GetPlatformCredential());
- CredentialManagerClient::From(script_state->GetExecutionContext())
+ CredentialManagerClient::From(ExecutionContext::From(script_state))
->DispatchStore(*web_credential, new NotificationCallbacks(resolver));
return promise;
}
@@ -213,7 +213,7 @@
if (!CheckBoilerplate(resolver))
return promise;
- CredentialManagerClient::From(script_state->GetExecutionContext())
+ CredentialManagerClient::From(ExecutionContext::From(script_state))
->DispatchRequireUserMediation(new NotificationCallbacks(resolver));
return promise;
}

Powered by Google App Engine
This is Rietveld 408576698