Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2815253002: Reland of Using multi-tab story in TabSwitching Benchmark (Closed)

Created:
3 years, 8 months ago by vovoy
Modified:
3 years, 8 months ago
Reviewers:
nednguyen, deanliao, perezju
CC:
chromium-reviews, telemetry-reviews_chromium.org, bccheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Using multi-tab story in TabSwitching Benchmark (patchset #1 id:1 of https://codereview.chromium.org/2809813003/ ) Using multi-tab story in TabSwitching Benchmark and rewrite measurement to fit the new multi-tab story Previous revert is due to tab_swichting mac flaky issue (https://bugs.chromium.org/p/chromium/issues/detail?id=634378), disable unittest on mac BUG=689388 Review-Url: https://codereview.chromium.org/2815253002 Cr-Commit-Position: refs/heads/master@{#464686} Committed: https://chromium.googlesource.com/chromium/src/+/d3e05d4115ef781866b26a09c619e88c2bec603b

Patch Set 1 #

Patch Set 2 : Reland of Using multi-tab story in TabSwitching Benchmark #

Patch Set 3 : Reland of Using multi-tab story in TabSwitching Benchmark #

Patch Set 4 : disable mac on perf unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -113 lines) Patch
M tools/perf/benchmarks/tab_switching.py View 1 2 chunks +6 lines, -4 lines 0 comments Download
M tools/perf/measurements/tab_switching.py View 1 1 chunk +17 lines, -87 lines 0 comments Download
M tools/perf/measurements/tab_switching_unittest.py View 1 2 3 4 chunks +40 lines, -20 lines 0 comments Download
M tools/perf/page_sets/system_health/multi_tab_stories.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 45 (39 generated)
vovoy
Created Reland of Using multi-tab story in TabSwitching Benchmark
3 years, 8 months ago (2017-04-13 03:27:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815253002/1
3 years, 8 months ago (2017-04-13 03:28:01 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-13 03:28:03 UTC) #5
perezju
lgtm
3 years, 8 months ago (2017-04-13 09:35:19 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815253002/160001
3 years, 8 months ago (2017-04-14 05:44:58 UTC) #42
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 06:07:52 UTC) #45
Message was sent while issue was closed.
Committed patchset #4 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/d3e05d4115ef781866b26a09c619...

Powered by Google App Engine
This is Rietveld 408576698