|
|
DescriptionReland of Using multi-tab story in TabSwitching Benchmark (patchset #1 id:1 of https://codereview.chromium.org/2809813003/ )
Using multi-tab story in TabSwitching Benchmark and rewrite measurement to fit the new multi-tab story
Previous revert is due to tab_swichting mac flaky issue
(https://bugs.chromium.org/p/chromium/issues/detail?id=634378),
disable unittest on mac
BUG=689388
Review-Url: https://codereview.chromium.org/2815253002
Cr-Commit-Position: refs/heads/master@{#464686}
Committed: https://chromium.googlesource.com/chromium/src/+/d3e05d4115ef781866b26a09c619e88c2bec603b
Patch Set 1 #Patch Set 2 : Reland of Using multi-tab story in TabSwitching Benchmark #Patch Set 3 : Reland of Using multi-tab story in TabSwitching Benchmark #Patch Set 4 : disable mac on perf unittest #
Messages
Total messages: 45 (39 generated)
The CQ bit was checked by vovoy@chromium.org
Created Reland of Using multi-tab story in TabSwitching Benchmark
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== Reland of Using multi-tab story in TabSwitching Benchmark (patchset #1 id:1 of https://codereview.chromium.org/2809813003/ ) Reason for revert: Reenable "Using multi-tab story in TabSwitching Benchmark" Original issue's description: > Revert of Using multi-tab story in TabSwitching Benchmark (patchset #12 id:220001 of https://codereview.chromium.org/2766533002/ ) > > Reason for revert: > It looks like this caused some breakage on Mac telemetry_perf_unittests: https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/10856 > > Original issue's description: > > Using multi-tab story in TabSwitching Benchmark and rewrite measurement > > to fit the new multi-tab story > > > > BUG=689388 > > > > Review-Url: https://codereview.chromium.org/2766533002 > > Cr-Commit-Position: refs/heads/master@{#463563} > > Committed: https://chromium.googlesource.com/chromium/src/+/cd01f90472cd2aa9fa824c902f39... > > TBR=nednguyen@google.com,deanliao@chromium.org,achuith@chromium.org,bccheng@c... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=689388 > > Review-Url: https://codereview.chromium.org/2809813003 > Cr-Commit-Position: refs/heads/master@{#463596} > Committed: https://chromium.googlesource.com/chromium/src/+/c11680219c62c4276972d72d6cb0... TBR=nednguyen@google.com,deanliao@chromium.org,achuith@chromium.org,bccheng@c... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=689388 ========== to ========== Reland of Using multi-tab story in TabSwitching Benchmark (patchset #1 id:1 of https://codereview.chromium.org/2809813003/ ) Using multi-tab story in TabSwitching Benchmark and rewrite measurement to fit the new multi-tab story Previous revert is due to tab_swichting mac flaky issue (https://bugs.chromium.org/p/chromium/issues/detail?id=634378) BUG=689388 ==========
vovoy@chromium.org changed reviewers: - achuith@chromium.org, bccheng@chromium.org, mkwst@chromium.org
Description was changed from ========== Reland of Using multi-tab story in TabSwitching Benchmark (patchset #1 id:1 of https://codereview.chromium.org/2809813003/ ) Using multi-tab story in TabSwitching Benchmark and rewrite measurement to fit the new multi-tab story Previous revert is due to tab_swichting mac flaky issue (https://bugs.chromium.org/p/chromium/issues/detail?id=634378) BUG=689388 ========== to ========== Reland of Using multi-tab story in TabSwitching Benchmark (patchset #1 id:1 of https://codereview.chromium.org/2809813003/ ) Using multi-tab story in TabSwitching Benchmark and rewrite measurement to fit the new multi-tab story Previous revert is due to tab_swichting mac flaky issue (https://bugs.chromium.org/p/chromium/issues/detail?id=634378), disable unittest on mac BUG=689388 ==========
The CQ bit was checked by vovoy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by vovoy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by vovoy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by vovoy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by vovoy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by vovoy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by vovoy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by vovoy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by vovoy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from perezju@chromium.org Link to the patchset: https://codereview.chromium.org/2815253002/#ps160001 (title: "disable mac on perf unittest")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 160001, "attempt_start_ts": 1492148678081170, "parent_rev": "736905bd65b4d98dccea3849185b12867030b187", "commit_rev": "d3e05d4115ef781866b26a09c619e88c2bec603b"}
Message was sent while issue was closed.
Description was changed from ========== Reland of Using multi-tab story in TabSwitching Benchmark (patchset #1 id:1 of https://codereview.chromium.org/2809813003/ ) Using multi-tab story in TabSwitching Benchmark and rewrite measurement to fit the new multi-tab story Previous revert is due to tab_swichting mac flaky issue (https://bugs.chromium.org/p/chromium/issues/detail?id=634378), disable unittest on mac BUG=689388 ========== to ========== Reland of Using multi-tab story in TabSwitching Benchmark (patchset #1 id:1 of https://codereview.chromium.org/2809813003/ ) Using multi-tab story in TabSwitching Benchmark and rewrite measurement to fit the new multi-tab story Previous revert is due to tab_swichting mac flaky issue (https://bugs.chromium.org/p/chromium/issues/detail?id=634378), disable unittest on mac BUG=689388 Review-Url: https://codereview.chromium.org/2815253002 Cr-Commit-Position: refs/heads/master@{#464686} Committed: https://chromium.googlesource.com/chromium/src/+/d3e05d4115ef781866b26a09c619... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:160001) as https://chromium.googlesource.com/chromium/src/+/d3e05d4115ef781866b26a09c619... |