Using multi-tab story in TabSwitching Benchmark

Using multi-tab story in TabSwitching Benchmark and rewrite measurement
to fit the new multi-tab story

BUG=689388
Review-Url: https://codereview.chromium.org/2766533002
Cr-Commit-Position: refs/heads/master@{#463563}
Committed: https://chromium.googlesource.com/chromium/src/+/cd01f90472cd2aa9fa824c902f39d0b9e50e4fba

[vovoy, 2017-03-21 03:59:00]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 03:59:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 05:46:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 05:46:32]

Dry run: This issue passed the CQ dry run.

[vovoy, 2017-03-21 06:11:52]

Description was changed from

==========
Use the new story for TabSwitching Benchmark

BUG=689388
==========

to

==========
Using the new multi-tab story to refactor TabSwitching Benchmark
and Measurement

BUG=689388
==========

[vovoy, 2017-03-21 06:12:00]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 06:12:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vovoy, 2017-03-21 06:14:31]

vovoy@chromium.org changed reviewers:
+ deanliao@chromium.org, nednguyen@google.com

[commit-bot: I haz the power, 2017-03-21 07:20:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 07:20:19]

Dry run: This issue passed the CQ dry run.

[vovoy, 2017-03-21 08:18:38]

I would like to refactor tab_switching benchmark and measure so it would be
easier to add options for adjust total tab counts to test (ex: --tab-repeat=2 to
double tab count)

There are 5 tab_switching benchmarks:
tab_switching.top_10
tab_switching.typical_25
tab_switching.five_blank_pages
tab_switching.tough_energy_cases
tab_switching.tough_image_cases
, and currently only 1 multi-tab story: multitab:misc:typical24

There are some options to refactor:
1. create a new measurement TabSwtiching2, tab_switching.typical_25 use the new
measurement, others keep using the original measurement TabSwtiching (this patch
set)
2. create other 4 multi-tab stories, all 5 tab_switching benchmark use the
refactored measurement, remove old measurement
3. remove part of the 5 tab_switching benchmarks
4. others?

Which option is preferred?

ref comment:
https://codereview.chromium.org/2706483003/#msg33
design doc:
https://docs.google.com/a/google.com/document/d/1rMrrlW4-5ZGD9dHxUYBOzzkS-vyX...

[nednguyen, 2017-03-21 14:46:12]

How about just keep one single tab_switching benchmark which is TabSwtiching2?

https://codereview.chromium.org/2766533002/diff/20001/tools/perf/measurements...
File tools/perf/measurements/tab_switching.py (right):

https://codereview.chromium.org/2766533002/diff/20001/tools/perf/measurements...
tools/perf/measurements/tab_switching.py:179: self._power_metric.Close()
Can you remove the legacy power_metric? The old power metric code is rotted &
its data are not trust-worthy, so our team is trying to get rid of it.

[vovoy, 2017-03-22 06:30:13]

On 2017/03/21 14:46:12, nednguyen wrote:
> How about just keep one single tab_switching benchmark which is TabSwtiching2?
> 
>
https://codereview.chromium.org/2766533002/diff/20001/tools/perf/measurements...
> File tools/perf/measurements/tab_switching.py (right):
> 
>
https://codereview.chromium.org/2766533002/diff/20001/tools/perf/measurements...
> tools/perf/measurements/tab_switching.py:179: self._power_metric.Close()
> Can you remove the legacy power_metric? The old power metric code is rotted &
> its data are not trust-worthy, so our team is trying to get rid of it.

I think it's better to have 2 CLs:
CL 1) remove 4 tab_switching benchmarks, only keep one: tab_switching.typical_25
CL 2) refactoring tab_switching measurement

I would create another CL for the first part.

[vovoy, 2017-03-23 03:34:31]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 03:34:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vovoy, 2017-03-23 03:46:19]

Description was changed from

==========
Using the new multi-tab story to refactor TabSwitching Benchmark
and Measurement

BUG=689388
==========

to

==========
Using multi-tab story in TabSwitching Benchmark and rewrite measurement
to fit the new multi-tab story

BUG=689388
==========

[commit-bot: I haz the power, 2017-03-23 03:50:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 03:50:48]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[vovoy, 2017-03-23 03:54:18]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 03:54:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 04:11:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 04:11:09]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[vovoy, 2017-03-23 05:20:22]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 05:20:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 05:35:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 05:35:42]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[vovoy, 2017-03-23 08:36:27]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 08:36:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 09:35:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 09:35:58]

Dry run: This issue passed the CQ dry run.

[vovoy, 2017-03-23 09:37:49]

the second part: refactoring tab_switching measurement

https://codereview.chromium.org/2766533002/diff/20001/tools/perf/measurements...
File tools/perf/measurements/tab_switching.py (right):

https://codereview.chromium.org/2766533002/diff/20001/tools/perf/measurements...
tools/perf/measurements/tab_switching.py:179: self._power_metric.Close()
On 2017/03/21 14:46:12, nednguyen wrote:
> Can you remove the legacy power_metric? The old power metric code is rotted &
> its data are not trust-worthy, so our team is trying to get rid of it.

Done.

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/measurement...
File tools/perf/measurements/tab_switching_unittest.py (left):

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/measurement...
tools/perf/measurements/tab_switching_unittest.py:68: # First _IsDone check for
tab_0. Retry.
_IsDone() check loop is removed in the written tab_switching measurement

[nednguyen, 2017-03-23 13:15:10]

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/benchmarks/...
File tools/perf/benchmarks/tab_switching.py (right):

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/benchmarks/...
tools/perf/benchmarks/tab_switching.py:14: @benchmark.Disabled('android')  #
http://crbug.com/460084
Can you add @benchmark.Owner(..) for this?

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/measurement...
File tools/perf/measurements/tab_switching_unittest.py (right):

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/measurement...
tools/perf/measurements/tab_switching_unittest.py:72: mock_get_histogram =
mock.MagicMock(side_effect=expected_histogram)
I really like to get away with using mock here because it won't let we know when
the histogram in the actual Chrome binary break. Can you just use a real test
mulitab story instead?

[vovoy, 2017-03-23 15:23:41]

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/benchmarks/...
File tools/perf/benchmarks/tab_switching.py (right):

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/benchmarks/...
tools/perf/benchmarks/tab_switching.py:14: @benchmark.Disabled('android')  #
http://crbug.com/460084
On 2017/03/23 13:15:10, nednguyen wrote:
> Can you add @benchmark.Owner(..) for this?

do you mean the following?
@benchmark.Owner(emails=['vovoy@chromium.org'])

[nednguyen, 2017-03-23 15:24:07]

On 2017/03/23 15:23:41, vovoy wrote:
>
https://codereview.chromium.org/2766533002/diff/100001/tools/perf/benchmarks/...
> File tools/perf/benchmarks/tab_switching.py (right):
> 
>
https://codereview.chromium.org/2766533002/diff/100001/tools/perf/benchmarks/...
> tools/perf/benchmarks/tab_switching.py:14: @benchmark.Disabled('android')  #
> http://crbug.com/460084
> On 2017/03/23 13:15:10, nednguyen wrote:
> > Can you add @benchmark.Owner(..) for this?
> 
> do you mean the following?
> mailto:@benchmark.Owner(emails=[

yes, can you add so add a component for ChromeOS team?

[vovoy, 2017-03-23 16:14:16]

On 2017/03/23 15:24:07, nednguyen wrote:
> On 2017/03/23 15:23:41, vovoy wrote:
> >
>
https://codereview.chromium.org/2766533002/diff/100001/tools/perf/benchmarks/...
> > File tools/perf/benchmarks/tab_switching.py (right):
> > 
> >
>
https://codereview.chromium.org/2766533002/diff/100001/tools/perf/benchmarks/...
> > tools/perf/benchmarks/tab_switching.py:14: @benchmark.Disabled('android')  #
> > http://crbug.com/460084
> > On 2017/03/23 13:15:10, nednguyen wrote:
> > > Can you add @benchmark.Owner(..) for this?
> > 
> > do you mean the following?
> > mailto:@benchmark.Owner(emails=[
> 
> yes, can you add so add a component for ChromeOS team?

@benchmark.Owner(emails=['vovoy@chromium.org'], component='Testing>ChromeOS') ?
How to add component "Testing>ChromeOS" ?

[vovoy, 2017-03-23 16:55:58]

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/measurement...
File tools/perf/measurements/tab_switching_unittest.py (right):

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/measurement...
tools/perf/measurements/tab_switching_unittest.py:72: mock_get_histogram =
mock.MagicMock(side_effect=expected_histogram)
On 2017/03/23 13:15:10, nednguyen wrote:
> I really like to get away with using mock here because it won't let we know
when
> the histogram in the actual Chrome binary break. Can you just use a real test
> mulitab story instead?

I think unittest shall test one thing at a time.
in measurements/tab_switching_unittest.py, shall only test code in
measurements/tab_switching.py .
it's unittest's advantage to test independently from a Chrome binary.

[vovoy, 2017-03-23 23:33:19]

vovoy@chromium.org changed reviewers:
+ achuith@chromium.org, bccheng@chromium.org

[vovoy, 2017-03-23 23:46:02]

On 2017/03/23 15:24:07, nednguyen wrote:
> On 2017/03/23 15:23:41, vovoy wrote:
> >
>
https://codereview.chromium.org/2766533002/diff/100001/tools/perf/benchmarks/...
> > File tools/perf/benchmarks/tab_switching.py (right):
> > 
> >
>
https://codereview.chromium.org/2766533002/diff/100001/tools/perf/benchmarks/...
> > tools/perf/benchmarks/tab_switching.py:14: @benchmark.Disabled('android')  #
> > http://crbug.com/460084
> > On 2017/03/23 13:15:10, nednguyen wrote:
> > > Can you add @benchmark.Owner(..) for this?
> > 
> > do you mean the following?
> > mailto:@benchmark.Owner(emails=[
> 
> yes, can you add so add a component for ChromeOS team?

achuithb: is there a bug component for ChromeOS ?

[nednguyen, 2017-03-23 23:49:06]

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/measurement...
File tools/perf/measurements/tab_switching_unittest.py (right):

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/measurement...
tools/perf/measurements/tab_switching_unittest.py:72: mock_get_histogram =
mock.MagicMock(side_effect=expected_histogram)
On 2017/03/23 16:55:58, vovoy wrote:
> On 2017/03/23 13:15:10, nednguyen wrote:
> > I really like to get away with using mock here because it won't let we know
> when
> > the histogram in the actual Chrome binary break. Can you just use a real
test
> > mulitab story instead?
> 
> I think unittest shall test one thing at a time.
> in measurements/tab_switching_unittest.py, shall only test code in
> measurements/tab_switching.py .
> it's unittest's advantage to test independently from a Chrome binary.

from my experience, these mock tests are mostly ineffective against catching
breakage & end up being guard changing test. 

You can keep a few unittest for logic that you think tricky, but I would
strongly encourage you to use real Chrome & add integration test that  assert
the metrics you expect to see are there (see:
https://cs.chromium.org/chromium/src/tools/perf/measurements/smoothness_unitt...)

[vovoy, 2017-03-24 00:25:51]

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/measurement...
File tools/perf/measurements/tab_switching_unittest.py (right):

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/measurement...
tools/perf/measurements/tab_switching_unittest.py:72: mock_get_histogram =
mock.MagicMock(side_effect=expected_histogram)
On 2017/03/23 23:49:06, nednguyen wrote:
> On 2017/03/23 16:55:58, vovoy wrote:
> > On 2017/03/23 13:15:10, nednguyen wrote:
> > > I really like to get away with using mock here because it won't let we
know
> > when
> > > the histogram in the actual Chrome binary break. Can you just use a real
> test
> > > mulitab story instead?
> > 
> > I think unittest shall test one thing at a time.
> > in measurements/tab_switching_unittest.py, shall only test code in
> > measurements/tab_switching.py .
> > it's unittest's advantage to test independently from a Chrome binary.
> 
> from my experience, these mock tests are mostly ineffective against catching
> breakage & end up being guard changing test. 
> 
> You can keep a few unittest for logic that you think tricky, but I would
> strongly encourage you to use real Chrome & add integration test that  assert
> the metrics you expect to see are there (see:
>
https://cs.chromium.org/chromium/src/tools/perf/measurements/smoothness_unitt...)

OK, I will check how smoothness_unittest works.

[vovoy, 2017-03-24 06:36:45]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 06:36:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 06:43:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 06:43:48]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vovoy, 2017-03-24 07:11:04]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 07:11:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vovoy, 2017-03-24 08:17:44]

vovoy@chromium.org changed reviewers:
+ perezju@chromium.org

[vovoy, 2017-03-24 08:25:00]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 08:25:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 09:26:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:26:43]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[vovoy, 2017-03-24 09:40:47]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 09:40:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 09:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:48:16]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vovoy, 2017-03-24 14:19:17]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 14:19:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vovoy, 2017-03-24 16:35:31]

added integration test and owner info

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/benchmarks/...
File tools/perf/benchmarks/tab_switching.py (right):

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/benchmarks/...
tools/perf/benchmarks/tab_switching.py:14: @benchmark.Disabled('android')  #
http://crbug.com/460084
On 2017/03/23 13:15:10, nednguyen wrote:
> Can you add @benchmark.Owner(..) for this?

Done.

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/measurement...
File tools/perf/measurements/tab_switching_unittest.py (right):

https://codereview.chromium.org/2766533002/diff/100001/tools/perf/measurement...
tools/perf/measurements/tab_switching_unittest.py:72: mock_get_histogram =
mock.MagicMock(side_effect=expected_histogram)
On 2017/03/23 23:49:06, nednguyen wrote:
> On 2017/03/23 16:55:58, vovoy wrote:
> > On 2017/03/23 13:15:10, nednguyen wrote:
> > > I really like to get away with using mock here because it won't let we
know
> > when
> > > the histogram in the actual Chrome binary break. Can you just use a real
> test
> > > mulitab story instead?
> > 
> > I think unittest shall test one thing at a time.
> > in measurements/tab_switching_unittest.py, shall only test code in
> > measurements/tab_switching.py .
> > it's unittest's advantage to test independently from a Chrome binary.
> 
> from my experience, these mock tests are mostly ineffective against catching
> breakage & end up being guard changing test. 
> 
> You can keep a few unittest for logic that you think tricky, but I would
> strongly encourage you to use real Chrome & add integration test that  assert
> the metrics you expect to see are there (see:
>
https://cs.chromium.org/chromium/src/tools/perf/measurements/smoothness_unitt...)

Done.

https://codereview.chromium.org/2766533002/diff/180001/tools/perf/benchmarks/...
File tools/perf/benchmarks/tab_switching.py (right):

https://codereview.chromium.org/2766533002/diff/180001/tools/perf/benchmarks/...
tools/perf/benchmarks/tab_switching.py:13: component='OS>Performance')
requested component OS>Performance:
https://bugs.chromium.org/p/chromium/issues/detail?id=704853

https://codereview.chromium.org/2766533002/diff/180001/tools/perf/page_sets/s...
File tools/perf/page_sets/system_health/multi_tab_stories.py (right):

https://codereview.chromium.org/2766533002/diff/180001/tools/perf/page_sets/s...
tools/perf/page_sets/system_health/multi_tab_stories.py:13: class
MultiTabStory(system_health_story.SystemHealthStory):
export MultiTabStory for testing

[commit-bot: I haz the power, 2017-03-24 17:06:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 17:06:22]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2017-03-27 17:10:43]

lgtm with nits

https://codereview.chromium.org/2766533002/diff/180001/tools/perf/measurement...
File tools/perf/measurements/tab_switching_unittest.py (right):

https://codereview.chromium.org/2766533002/diff/180001/tools/perf/measurement...
tools/perf/measurements/tab_switching_unittest.py:113:
self.assertEquals(summary.name, 'MPArch_RWH_TabSwitchPaintDuration')
assert this is greater than zero?

[vovoy, 2017-03-28 08:12:51]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 08:13:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 10:47:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 10:47:15]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[vovoy, 2017-03-28 13:02:56]

https://codereview.chromium.org/2766533002/diff/180001/tools/perf/measurement...
File tools/perf/measurements/tab_switching_unittest.py (right):

https://codereview.chromium.org/2766533002/diff/180001/tools/perf/measurement...
tools/perf/measurements/tab_switching_unittest.py:113:
self.assertEquals(summary.name, 'MPArch_RWH_TabSwitchPaintDuration')
On 2017/03/27 17:10:43, nednguyen wrote:
> assert this is greater than zero?

Done, check that the mean of MPArch_RWH_TabSwitchPaintDuration is greater than 0

[vovoy, 2017-03-28 13:03:11]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 13:03:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 13:50:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 13:50:48]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2017-03-28 15:07:55]

On 2017/03/28 13:02:56, vovoy wrote:
>
https://codereview.chromium.org/2766533002/diff/180001/tools/perf/measurement...
> File tools/perf/measurements/tab_switching_unittest.py (right):
> 
>
https://codereview.chromium.org/2766533002/diff/180001/tools/perf/measurement...
> tools/perf/measurements/tab_switching_unittest.py:113:
> self.assertEquals(summary.name, 'MPArch_RWH_TabSwitchPaintDuration')
> On 2017/03/27 17:10:43, nednguyen wrote:
> > assert this is greater than zero?
> 
> Done, check that the mean of MPArch_RWH_TabSwitchPaintDuration is greater than
0

lgtm

[nednguyen, 2017-04-10 14:21:16]

On 2017/03/28 15:07:55, nednguyen (slow til 4-10) wrote:
> On 2017/03/28 13:02:56, vovoy wrote:
> >
>
https://codereview.chromium.org/2766533002/diff/180001/tools/perf/measurement...
> > File tools/perf/measurements/tab_switching_unittest.py (right):
> > 
> >
>
https://codereview.chromium.org/2766533002/diff/180001/tools/perf/measurement...
> > tools/perf/measurements/tab_switching_unittest.py:113:
> > self.assertEquals(summary.name, 'MPArch_RWH_TabSwitchPaintDuration')
> > On 2017/03/27 17:10:43, nednguyen wrote:
> > > assert this is greater than zero?
> > 
> > Done, check that the mean of MPArch_RWH_TabSwitchPaintDuration is greater
than
> 0
> 
> lgtm

Any progress on this?

[vovoy, 2017-04-11 02:44:34]

On 2017/04/10 14:21:16, nednguyen wrote:
> On 2017/03/28 15:07:55, nednguyen (slow til 4-10) wrote:
> > On 2017/03/28 13:02:56, vovoy wrote:
> > >
> >
>
https://codereview.chromium.org/2766533002/diff/180001/tools/perf/measurement...
> > > File tools/perf/measurements/tab_switching_unittest.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2766533002/diff/180001/tools/perf/measurement...
> > > tools/perf/measurements/tab_switching_unittest.py:113:
> > > self.assertEquals(summary.name, 'MPArch_RWH_TabSwitchPaintDuration')
> > > On 2017/03/27 17:10:43, nednguyen wrote:
> > > > assert this is greater than zero?
> > > 
> > > Done, check that the mean of MPArch_RWH_TabSwitchPaintDuration is greater
> than
> > 0
> > 
> > lgtm
> 
> Any progress on this?

I was waiting for OS>Performance component creation last week.
The new component has been created, so it's ready to commit.
https://bugs.chromium.org/p/chromium/issues/detail?id=704853#c5

[vovoy, 2017-04-11 02:45:44]

The CQ bit was checked by vovoy@chromium.org

[commit-bot: I haz the power, 2017-04-11 02:46:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 02:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 02:49:11]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[vovoy, 2017-04-11 02:59:23]

The CQ bit was checked by vovoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 03:00:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 05:24:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 05:24:28]

Dry run: This issue passed the CQ dry run.

[vovoy, 2017-04-11 07:21:06]

The CQ bit was checked by vovoy@chromium.org

[vovoy, 2017-04-11 07:21:07]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2766533002/#ps220001
(title: "fix merge conflict")

[commit-bot: I haz the power, 2017-04-11 07:21:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 07:26:04]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1491895266968930,
"parent_rev": "be4f080c9614b30236c8d4f642fdbea078954734", "commit_rev":
"cd01f90472cd2aa9fa824c902f39d0b9e50e4fba"}

[commit-bot: I haz the power, 2017-04-11 07:27:49]

Description was changed from

==========
Using multi-tab story in TabSwitching Benchmark and rewrite measurement
to fit the new multi-tab story

BUG=689388
==========

to

==========
Using multi-tab story in TabSwitching Benchmark and rewrite measurement
to fit the new multi-tab story

BUG=689388

Review-Url: https://codereview.chromium.org/2766533002
Cr-Commit-Position: refs/heads/master@{#463563}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd01f90472cd2aa9fa824c902f39...
==========

[commit-bot: I haz the power, 2017-04-11 07:27:51]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/cd01f90472cd2aa9fa824c902f39...

[Mike West, 2017-04-11 10:58:23]

A revert of this CL (patchset #12 id:220001) has been created in
https://codereview.chromium.org/2809813003/ by mkwst@chromium.org.

The reason for reverting is: It looks like this caused some breakage on Mac
telemetry_perf_unittests:
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/10856.