Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2809813003: Revert of Using multi-tab story in TabSwitching Benchmark (Closed)

Created:
3 years, 8 months ago by Mike West
Modified:
3 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Using multi-tab story in TabSwitching Benchmark (patchset #12 id:220001 of https://codereview.chromium.org/2766533002/ ) Reason for revert: It looks like this caused some breakage on Mac telemetry_perf_unittests: https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/10856 Original issue's description: > Using multi-tab story in TabSwitching Benchmark and rewrite measurement > to fit the new multi-tab story > > BUG=689388 > > Review-Url: https://codereview.chromium.org/2766533002 > Cr-Commit-Position: refs/heads/master@{#463563} > Committed: https://chromium.googlesource.com/chromium/src/+/cd01f90472cd2aa9fa824c902f39d0b9e50e4fba TBR=nednguyen@google.com,deanliao@chromium.org,achuith@chromium.org,bccheng@chromium.org,perezju@chromium.org,vovoy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=689388 Review-Url: https://codereview.chromium.org/2809813003 Cr-Commit-Position: refs/heads/master@{#463596} Committed: https://chromium.googlesource.com/chromium/src/+/c11680219c62c4276972d72d6cb0da91cb96b80e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -63 lines) Patch
M tools/perf/benchmarks/tab_switching.py View 2 chunks +1 line, -4 lines 0 comments Download
M tools/perf/measurements/tab_switching.py View 1 chunk +87 lines, -17 lines 0 comments Download
M tools/perf/measurements/tab_switching_unittest.py View 4 chunks +20 lines, -40 lines 0 comments Download
M tools/perf/page_sets/system_health/multi_tab_stories.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mike West
Created Revert of Using multi-tab story in TabSwitching Benchmark
3 years, 8 months ago (2017-04-11 10:58:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809813003/1
3 years, 8 months ago (2017-04-11 10:58:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c11680219c62c4276972d72d6cb0da91cb96b80e
3 years, 8 months ago (2017-04-11 11:00:08 UTC) #6
vovoy
3 years, 8 months ago (2017-04-13 03:27:03 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2815253002/ by vovoy@chromium.org.

The reason for reverting is: Reenable "Using multi-tab story in TabSwitching
Benchmark".

Powered by Google App Engine
This is Rietveld 408576698