Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2820533003: Make Script non-TraceWrapperBase and add a comment about ModuleScript tracing (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Script non-TraceWrapperBase and add a comment about ModuleScript tracing https://codereview.chromium.org/2780463002/ introduced Script as TraceWrapperBase, but after discussions Script doesn't needs to be TraceWrapperBase. This CL makes Script non-TraceWrapperBase and adds a comments describing why. BUG=594639, 686281 Review-Url: https://codereview.chromium.org/2820533003 Cr-Commit-Position: refs/heads/master@{#464608} Committed: https://chromium.googlesource.com/chromium/src/+/d1ed2867ffe879d6e1e404cb99c0a9713d7c3eb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M third_party/WebKit/Source/core/dom/ClassicScript.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ClassicScript.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ModuleScript.h View 3 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ModuleScript.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Script.h View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
hiroshige
PTAL.
3 years, 8 months ago (2017-04-13 18:10:39 UTC) #6
haraken
LGTM
3 years, 8 months ago (2017-04-13 23:04:14 UTC) #9
kouhei (in TOK)
lgtm
3 years, 8 months ago (2017-04-13 23:31:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820533003/1
3 years, 8 months ago (2017-04-13 23:31:45 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 23:39:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d1ed2867ffe879d6e1e404cb99c0...

Powered by Google App Engine
This is Rietveld 408576698