Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2815003002: [DevTools] Split InputModel out of screencast (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 2 weeks ago by dgozman
Modified:
3 months, 2 weeks ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Split InputModel out of screencast One more step to using models instead of raw agents. BUG=none Review-Url: https://codereview.chromium.org/2815003002 Cr-Commit-Position: refs/heads/master@{#464219} Committed: https://chromium.googlesource.com/chromium/src/+/6ad744b7136000d3b2cd44d0b1f86d12fdab6ff1

Patch Set 1 #

Total comments: 10

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -158 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js View 1 chunk +3 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js View 1 1 chunk +116 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js View 1 7 chunks +55 lines, -153 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js View 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/build/generate_protocol_externs.py View 1 chunk +1 line, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 14 (9 generated)
dgozman
Could you please take a look?
3 months, 2 weeks ago (2017-04-12 01:04:43 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js File third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js (right): https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js#newcode60 third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js:60: const buttons = {0: 'none', 1: 'left', 2: ...
3 months, 2 weeks ago (2017-04-12 01:27:54 UTC) #5
dgozman
https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js File third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js (right): https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js#newcode60 third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js:60: const buttons = {0: 'none', 1: 'left', 2: 'middle', ...
3 months, 2 weeks ago (2017-04-12 18:57:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815003002/20001
3 months, 2 weeks ago (2017-04-12 22:21:41 UTC) #11
commit-bot: I haz the power
3 months, 2 weeks ago (2017-04-13 00:23:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6ad744b7136000d3b2cd44d0b1f8...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973