Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2815003002: [DevTools] Split InputModel out of screencast (Closed)

Created:
1 year ago by dgozman
Modified:
1 year ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Split InputModel out of screencast One more step to using models instead of raw agents. BUG=none Review-Url: https://codereview.chromium.org/2815003002 Cr-Commit-Position: refs/heads/master@{#464219} Committed: https://chromium.googlesource.com/chromium/src/+/6ad744b7136000d3b2cd44d0b1f86d12fdab6ff1

Patch Set 1 #

Total comments: 10

Patch Set 2 : comments addressed #

Messages

Total messages: 14 (9 generated)
dgozman
Could you please take a look?
1 year ago (2017-04-12 01:04:43 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js File third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js (right): https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js#newcode60 third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js:60: const buttons = {0: 'none', 1: 'left', 2: ...
1 year ago (2017-04-12 01:27:54 UTC) #5
dgozman
https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js File third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js (right): https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js#newcode60 third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js:60: const buttons = {0: 'none', 1: 'left', 2: 'middle', ...
1 year ago (2017-04-12 18:57:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815003002/20001
1 year ago (2017-04-12 22:21:41 UTC) #11
commit-bot: I haz the power
1 year ago (2017-04-13 00:23:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6ad744b7136000d3b2cd44d0b1f8...

Powered by Google App Engine
This is Rietveld 408576698