third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js - Issue 2815003002: [DevTools] Split InputModel out of screencast

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

Issue 2815003002: [DevTools] Split InputModel out of screencast (Closed)

Patch Set: comments addressed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/BUILD.gn ('k') | third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js b/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

index 1662efc8e54489ae1dae19c73d80e7cadfc630d2..bdd4fbc35c83fed30f9eeb9e335db8f17655111c 100644

--- a/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

+++ b/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js

@@ -142,8 +142,9 @@ Audits2.Audits2Panel = class extends UI.Panel {

return this._protocolService.detach().then(_ => {

this._auditRunning = false;

this._updateButton();

- if (this._inspectedURL !== SDK.targetManager.mainTarget().inspectedURL())

- SDK.targetManager.mainTarget().pageAgent().navigate(this._inspectedURL);

+ var resourceTreeModel = SDK.targetManager.mainTarget().model(SDK.ResourceTreeModel);

+ if (resourceTreeModel && this._inspectedURL !== SDK.targetManager.mainTarget().inspectedURL())

+ resourceTreeModel.navigate(this._inspectedURL);

});

}