[DevTools] Split InputModel out of screencast

[DevTools] Split InputModel out of screencast

One more step to using models instead of raw agents.

BUG=none

Review-Url: https://codereview.chromium.org/2815003002
Cr-Commit-Position: refs/heads/master@{#464219}
Committed: https://chromium.googlesource.com/chromium/src/+/6ad744b7136000d3b2cd44d0b1f86d12fdab6ff1

[dgozman, 2017-04-12 01:04:42]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2017-04-12 01:04:43]

Could you please take a look?

[dgozman, 2017-04-12 01:04:47]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 01:05:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-04-12 01:27:54]

lgtm

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js
(right):

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js:60: const
buttons = {0: 'none', 1: 'left', 2: 'middle', 3: 'right'};
s/const/var

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js:76:
(event.altKey ? 1 : 0) | (event.ctrlKey ? 2 : 0) | (event.metaKey ? 4 : 0) |
(event.shiftKey ? 8 : 0);
you can use _modifiersForEvent!

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js:101:
dispatchTouchOnBlur() {
cancelTouch

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
(right):

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js:226:
this._inputModel.dispatchTouchEventFromMouse(event, this._screenOffsetTop,
this._screenZoom);
emit? to not clash with out event system

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js:613:
this._navigationBack.addEventListener('click',
this._navigateToHistoryEntry.bind(this, -1), false);
let's add this listeners only in case of existance of ResourceTreeModel

[commit-bot: I haz the power, 2017-04-12 03:04:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 03:04:27]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-12 18:57:44]

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js
(right):

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js:60: const
buttons = {0: 'none', 1: 'left', 2: 'middle', 3: 'right'};
On 2017/04/12 01:27:54, lushnikov wrote:
> s/const/var

Done.

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js:76:
(event.altKey ? 1 : 0) | (event.ctrlKey ? 2 : 0) | (event.metaKey ? 4 : 0) |
(event.shiftKey ? 8 : 0);
On 2017/04/12 01:27:54, lushnikov wrote:
> you can use _modifiersForEvent!

Done.

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/screencast/InputModel.js:101:
dispatchTouchOnBlur() {
On 2017/04/12 01:27:54, lushnikov wrote:
> cancelTouch

Done.

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
(right):

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js:226:
this._inputModel.dispatchTouchEventFromMouse(event, this._screenOffsetTop,
this._screenZoom);
On 2017/04/12 01:27:54, lushnikov wrote:
> emit? to not clash with out event system

Done.

https://codereview.chromium.org/2815003002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js:613:
this._navigationBack.addEventListener('click',
this._navigateToHistoryEntry.bind(this, -1), false);
On 2017/04/12 01:27:54, lushnikov wrote:
> let's add this listeners only in case of existance of ResourceTreeModel

Done.

[dgozman, 2017-04-12 22:21:05]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2017-04-12 22:21:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2815003002/#ps20001
(title: "comments addressed")

[commit-bot: I haz the power, 2017-04-12 22:21:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 00:22:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492035665545630,
"parent_rev": "52ecff3c080ea3727c0948d404dfeedf7022ce88", "commit_rev":
"6ad744b7136000d3b2cd44d0b1f86d12fdab6ff1"}

[commit-bot: I haz the power, 2017-04-13 00:23:07]

Description was changed from

==========
[DevTools] Split InputModel out of screencast

One more step to using models instead of raw agents.

BUG=none
==========

to

==========
[DevTools] Split InputModel out of screencast

One more step to using models instead of raw agents.

BUG=none

Review-Url: https://codereview.chromium.org/2815003002
Cr-Commit-Position: refs/heads/master@{#464219}
Committed:
https://chromium.googlesource.com/chromium/src/+/6ad744b7136000d3b2cd44d0b1f8...
==========

[commit-bot: I haz the power, 2017-04-13 00:23:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6ad744b7136000d3b2cd44d0b1f8...