Blink Rename follow-up: S3TCsRGB should become _s3tc_srgb (not _s3t_cs_rgb).

Blink Rename follow-up: S3TCsRGB should become _s3tc_srgb (not _s3t_cs_rgb).

The clang tool had a bug in how it processes variables named
fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz.  Examples
include URLs -> ur_ls and XHRs -> xh_rs.

No intended behavior change.

BUG=675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2814853002
Cr-Commit-Position: refs/heads/master@{#464341}
Committed: https://chromium.googlesource.com/chromium/src/+/cf158122b56fbd907a875438a4e2c40193be6f07

[Łukasz Anforowicz, 2017-04-11 20:13:35]

Description was changed from

==========
Blink Rename follow-up: S3TCs --big-rename--> _s3t_cs --this-fix--> _s3tcs.

The clang tool had a bug in how it processes variables named
fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz.  Examples
include URLs -> ur_ls and XHRs -> xh_rs.

No intended behavior change.

BUG=675877
==========

to

==========
Blink Rename follow-up: S3TCs --big-rename--> _s3t_cs --this-fix--> _s3tcs.

The clang tool had a bug in how it processes variables named
fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz.  Examples
include URLs -> ur_ls and XHRs -> xh_rs.

No intended behavior change.

BUG=675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Łukasz Anforowicz, 2017-04-11 20:13:38]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 20:14:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-04-11 20:15:18]

lukasza@chromium.org changed reviewers:
+ bajones@chromium.org

[Łukasz Anforowicz, 2017-04-11 20:15:18]

bajones@, could you PTAL?

[commit-bot: I haz the power, 2017-04-11 22:42:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 22:42:15]

Dry run: This issue passed the CQ dry run.

[bajones, 2017-04-13 00:19:10]

On 2017/04/11 20:15:18, Łukasz A. wrote:
> bajones@, could you PTAL?

LGTM

[bajones, 2017-04-13 00:21:39]

On 2017/04/13 00:19:10, bajones wrote:
> On 2017/04/11 20:15:18, Łukasz A. wrote:
> > bajones@, could you PTAL?
> 
> LGTM

Oh, wait! I take it back! We want these to be "s3tc_srgb_" (S3TC being a texture
format, SRGB being a color space)

[Łukasz Anforowicz, 2017-04-13 04:05:54]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 04:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-04-13 04:06:59]

On 2017/04/13 00:21:39, bajones wrote:
> On 2017/04/13 00:19:10, bajones wrote:
> > On 2017/04/11 20:15:18, Łukasz A. wrote:
> > > bajones@, could you PTAL?
> > 
> > LGTM
> 
> Oh, wait! I take it back! We want these to be "s3tc_srgb_" (S3TC being a
texture
> format, SRGB being a color space)

Great - thanks for catching my mistake here.  I was too focused on fixing plural
forms (URLs, XHRs) elsewhere eto realize that this is meant to spell "srgb".

Done.

[Łukasz Anforowicz, 2017-04-13 04:19:00]

Description was changed from

==========
Blink Rename follow-up: S3TCs --big-rename--> _s3t_cs --this-fix--> _s3tcs.

The clang tool had a bug in how it processes variables named
fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz.  Examples
include URLs -> ur_ls and XHRs -> xh_rs.

No intended behavior change.

BUG=675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Blink Rename follow-up: S3TCsRGB should become _s3tc_srgb (not _s3t_cs_rgb).

The clang tool had a bug in how it processes variables named
fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz.  Examples
include URLs -> ur_ls and XHRs -> xh_rs.

No intended behavior change.

BUG=675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Łukasz Anforowicz, 2017-04-13 04:19:38]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-04-13 04:19:45]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-04-13 04:19:45]

The patchset sent to the CQ was uploaded after l-g-t-m from bajones@chromium.org
Link to the patchset: https://codereview.chromium.org/2814853002/#ps20001
(title: "Changed the spelling to ...s3tc_srgb_...")

[commit-bot: I haz the power, 2017-04-13 04:20:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 08:39:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492057185025160,
"parent_rev": "a1644c12446b4d6638ea52d567bc92eef927d61b", "commit_rev":
"cf158122b56fbd907a875438a4e2c40193be6f07"}

[commit-bot: I haz the power, 2017-04-13 08:40:23]

Description was changed from

==========
Blink Rename follow-up: S3TCsRGB should become _s3tc_srgb (not _s3t_cs_rgb).

The clang tool had a bug in how it processes variables named
fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz.  Examples
include URLs -> ur_ls and XHRs -> xh_rs.

No intended behavior change.

BUG=675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Blink Rename follow-up: S3TCsRGB should become _s3tc_srgb (not _s3t_cs_rgb).

The clang tool had a bug in how it processes variables named
fooBARsBaz into foo_ba_rs_baz rather than foo_bars_baz.  Examples
include URLs -> ur_ls and XHRs -> xh_rs.

No intended behavior change.

BUG=675877
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2814853002
Cr-Commit-Position: refs/heads/master@{#464341}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf158122b56fbd907a875438a4e2...
==========

[commit-bot: I haz the power, 2017-04-13 08:40:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cf158122b56fbd907a875438a4e2...