Make blink::ResourceRequest ctors explicit

Make blink::ResourceRequest ctors explicit

This CL adds `explicit` to blink::ResourceRequest ctors and fixes errors
after that.
The implicit conversion is generally discouraged, and prevents further
refactoring around ResourceRequest.

Review-Url: https://codereview.chromium.org/2814703004
Cr-Commit-Position: refs/heads/master@{#465172}
Committed: https://chromium.googlesource.com/chromium/src/+/4935fa77433b9e5ceb50575a4ec9d1ac4e797235

[tzik, 2017-04-12 10:44:09]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 10:44:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-04-12 10:48:41]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 10:48:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-04-12 10:52:23]

Description was changed from

==========
Make blink::ResourceRequest ctors explicit

BUG=
==========

to

==========
Make blink::ResourceRequest ctors explicit

BUG=
==========

[tzik, 2017-04-12 10:52:23]

tzik@chromium.org changed reviewers:
+ yhirano@chromium.org

[tzik, 2017-04-12 10:52:53]

tzik@chromium.org changed reviewers:
+ kinuko@chromium.org

[tzik, 2017-04-12 10:54:04]

tzik@chromium.org changed reviewers:
+ tkent@chromium.org

[commit-bot: I haz the power, 2017-04-12 12:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 12:43:42]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-04-13 06:21:44]

Description was changed from

==========
Make blink::ResourceRequest ctors explicit

BUG=
==========

to

==========
Make blink::ResourceRequest ctors explicit

This CL adds `explicit` to blink::ResourceRequest ctors and fixes errors
after that.
The implicit conversion is generally discouraged, and prevents further
refactoring around ResourceRequest.
==========

[tzik, 2017-04-13 06:23:32]

PTAL to:
yhirano: core/loader/, platform/loader/
kinuko: other core/
tkent: web/

[kouhei (in TOK), 2017-04-13 06:25:27]

kouhei@chromium.org changed reviewers:
+ kouhei@chromium.org

[kouhei (in TOK), 2017-04-13 06:25:27]

core lgtm

[tkent, 2017-04-13 06:30:46]

lgtm

[kinuko, 2017-04-13 06:32:23]

lgtm

Can you put BUG= line if it's related to the series of cleanups you briefly
mentioned yesterday?

[haraken, 2017-04-13 06:39:34]

LGTM

[yhirano, 2017-04-13 14:20:55]

lgtm

[tzik, 2017-04-17 08:40:49]

On 2017/04/13 06:32:23, kinuko wrote:
> lgtm
> 
> Can you put BUG= line if it's related to the series of cleanups you briefly
> mentioned yesterday?

This is a drive-by clean up in an attempt to fix a UAF crash, but, as we
discussed in a meeting last Friday, we should probably hold the following
refactoring for a while to see whether other fixes take effect.
I'll file a bug with a doc after I resume it later.

[tzik, 2017-04-18 05:39:55]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2017-04-18 05:40:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 07:38:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492493995356020,
"parent_rev": "56866c20d1252bb4ad9a6a0ed51a14fa73b7632f", "commit_rev":
"4935fa77433b9e5ceb50575a4ec9d1ac4e797235"}

[commit-bot: I haz the power, 2017-04-18 07:39:01]

Description was changed from

==========
Make blink::ResourceRequest ctors explicit

This CL adds `explicit` to blink::ResourceRequest ctors and fixes errors
after that.
The implicit conversion is generally discouraged, and prevents further
refactoring around ResourceRequest.
==========

to

==========
Make blink::ResourceRequest ctors explicit

This CL adds `explicit` to blink::ResourceRequest ctors and fixes errors
after that.
The implicit conversion is generally discouraged, and prevents further
refactoring around ResourceRequest.

Review-Url: https://codereview.chromium.org/2814703004
Cr-Commit-Position: refs/heads/master@{#465172}
Committed:
https://chromium.googlesource.com/chromium/src/+/4935fa77433b9e5ceb50575a4ec9...
==========

[commit-bot: I haz the power, 2017-04-18 07:39:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4935fa77433b9e5ceb50575a4ec9...