Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Side by Side Diff: third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h

Issue 2814703004: Make blink::ResourceRequest ctors explicit (Closed)
Patch Set: simplify Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2003, 2006 Apple Computer, Inc. All rights reserved.
3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 4 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 68
69 public: 69 public:
70 enum class RedirectStatus { kFollowedRedirect, kNoRedirect }; 70 enum class RedirectStatus { kFollowedRedirect, kNoRedirect };
71 71
72 class ExtraData : public RefCounted<ExtraData> { 72 class ExtraData : public RefCounted<ExtraData> {
73 public: 73 public:
74 virtual ~ExtraData() {} 74 virtual ~ExtraData() {}
75 }; 75 };
76 76
77 ResourceRequest(); 77 ResourceRequest();
78 ResourceRequest(const String& url_string); 78 explicit ResourceRequest(const String& url_string);
79 ResourceRequest(const KURL&); 79 explicit ResourceRequest(const KURL&);
80 explicit ResourceRequest(CrossThreadResourceRequestData*); 80 explicit ResourceRequest(CrossThreadResourceRequestData*);
81 ResourceRequest(const ResourceRequest&); 81 ResourceRequest(const ResourceRequest&);
82 ResourceRequest& operator=(const ResourceRequest&); 82 ResourceRequest& operator=(const ResourceRequest&);
83 83
84 // Gets a copy of the data suitable for passing to another thread. 84 // Gets a copy of the data suitable for passing to another thread.
85 std::unique_ptr<CrossThreadResourceRequestData> CopyData() const; 85 std::unique_ptr<CrossThreadResourceRequestData> CopyData() const;
86 86
87 bool IsNull() const; 87 bool IsNull() const;
88 bool IsEmpty() const; 88 bool IsEmpty() const;
89 89
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 bool check_for_browser_side_navigation_; 410 bool check_for_browser_side_navigation_;
411 double ui_start_time_; 411 double ui_start_time_;
412 bool is_external_request_; 412 bool is_external_request_;
413 InputToLoadPerfMetricReportPolicy input_perf_metric_report_policy_; 413 InputToLoadPerfMetricReportPolicy input_perf_metric_report_policy_;
414 ResourceRequest::RedirectStatus redirect_status_; 414 ResourceRequest::RedirectStatus redirect_status_;
415 }; 415 };
416 416
417 } // namespace blink 417 } // namespace blink
418 418
419 #endif // ResourceRequest_h 419 #endif // ResourceRequest_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698