Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: third_party/WebKit/Source/core/page/CreateWindow.cpp

Issue 2814703004: Make blink::ResourceRequest ctors explicit (Closed)
Patch Set: simplify Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/CreateWindow.cpp
diff --git a/third_party/WebKit/Source/core/page/CreateWindow.cpp b/third_party/WebKit/Source/core/page/CreateWindow.cpp
index 4522288b1293852d9c1dabf7b573c74a71ae39b4..2d2321c054a47ad2d183d89d4dc3d7fbb4d97b23 100644
--- a/third_party/WebKit/Source/core/page/CreateWindow.cpp
+++ b/third_party/WebKit/Source/core/page/CreateWindow.cpp
@@ -195,8 +195,8 @@ DOMWindow* CreateWindow(const String& url_string,
return nullptr;
}
- FrameLoadRequest frame_request(calling_window.document(), completed_url,
- frame_name);
+ FrameLoadRequest frame_request(calling_window.document(),
+ ResourceRequest(completed_url), frame_name);
frame_request.SetShouldSetOpener(window_features.noopener ? kNeverSetOpener
: kMaybeSetOpener);
frame_request.GetResourceRequest().SetFrameType(
@@ -243,7 +243,8 @@ DOMWindow* CreateWindow(const String& url_string,
// causes the navigation to be flagged as a client redirect, which is
// observable via the webNavigation extension api.
if (created) {
- FrameLoadRequest request(calling_window.document(), completed_url);
+ FrameLoadRequest request(calling_window.document(),
+ ResourceRequest(completed_url));
request.GetResourceRequest().SetHasUserGesture(has_user_gesture);
new_frame->Navigate(request);
} else if (!url_string.IsEmpty()) {

Powered by Google App Engine
This is Rietveld 408576698