Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2814603003: [Android O] Split out browser notification channels (Closed)

Created:
3 years, 8 months ago by awdf
Modified:
3 years, 8 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, awdf+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, feature-media-reviews_chromium.org, agrieve+watch_chromium.org, srahim+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android O] Split out browser notification channels - Incognito, Media, and Download notifications are all now posted to their own special channels, which are created on startup. - The Browser channel remains for all other misc browser notifications. BUG=704978 Review-Url: https://codereview.chromium.org/2814603003 Cr-Commit-Position: refs/heads/master@{#464079} Committed: https://chromium.googlesource.com/chromium/src/+/0ecaeb804b4aab2c9aad6953954705499d2ad4a1

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase; edit media string description #

Patch Set 3 : rebase #

Patch Set 4 : Fix up ChannelsUpdaterTest expectations #

Messages

Total messages: 21 (13 generated)
awdf
Told you this would be simple! Note this depends on the two channels initialization reviews ...
3 years, 8 months ago (2017-04-11 16:53:33 UTC) #2
Peter Beverloo
lgtm! https://codereview.chromium.org/2814603003/diff/1/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2814603003/diff/1/chrome/android/java/strings/android_chrome_strings.grd#newcode256 chrome/android/java/strings/android_chrome_strings.grd:256: <message name="IDS_NOTIFICATION_CATEGORY_MEDIA" desc="Label for notifications shown when media ...
3 years, 8 months ago (2017-04-11 17:49:07 UTC) #5
awdf
+nyquist@ for owners review - Tommy please take a look, thanks! https://codereview.chromium.org/2814603003/diff/1/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): ...
3 years, 8 months ago (2017-04-11 18:59:04 UTC) #9
nyquist
lgtm!
3 years, 8 months ago (2017-04-11 19:36:38 UTC) #11
David Trainor- moved to gerrit
lgtm!?
3 years, 8 months ago (2017-04-11 20:43:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814603003/40001
3 years, 8 months ago (2017-04-12 16:04:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814603003/60001
3 years, 8 months ago (2017-04-12 17:10:51 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 17:56:01 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0ecaeb804b4aab2c9aad69539547...

Powered by Google App Engine
This is Rietveld 408576698