chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java - Issue 2814603003: [Android O] Split out browser notification channels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

Issue 2814603003: [Android O] Split out browser notification channels (Closed)

Patch Set: Fix up ChannelsUpdaterTest expectations Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

index 471fdd55f5dfc667f1af0fb81bb65459a6052de1..f4d1eacf9b43598f54808a339dc235c697fd8351 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java

@@ -368,7 +368,7 @@ public class DownloadNotificationService extends Service {

ChromeNotificationBuilder builder =

NotificationBuilderFactory

.createChromeNotificationBuilder(

- true /* preferCompat */, ChannelsInitializer.CHANNEL_ID_BROWSER)

+ true /* preferCompat */, ChannelsInitializer.CHANNEL_ID_DOWNLOADS)

.setContentTitle(

context.getString(R.string.download_notification_summary_title))

.setSubText(context.getString(R.string.menu_downloads))

@@ -1079,7 +1079,7 @@ public class DownloadNotificationService extends Service {

ChromeNotificationBuilder builder =

NotificationBuilderFactory

.createChromeNotificationBuilder(

- true /* preferCompat */, ChannelsInitializer.CHANNEL_ID_BROWSER)

+ true /* preferCompat */, ChannelsInitializer.CHANNEL_ID_DOWNLOADS)

.setContentTitle(

DownloadUtils.getAbbreviatedFileName(title, MAX_FILE_NAME_LENGTH))

.setSmallIcon(iconId)

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationManager.java » ('j') | no next file with comments »