Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2814253002: IndexedDB: Fix mocks/comments following the great blink rename (Closed)

Created:
3 years, 8 months ago by jsbell
Modified:
3 years, 8 months ago
Reviewers:
dmurph
CC:
chromium-reviews, haraken, blink-reviews, jsbell+idb_chromium.org, cmumford
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Fix mocks/comments following the great blink rename * Rename an internal-only overload of a web exposed method. * Fix method/identifier names that appear in comments. * Fix mocked method arguments. * Follow style guide for function argument comments. Review-Url: https://codereview.chromium.org/2814253002 Cr-Commit-Position: refs/heads/master@{#464254} Committed: https://chromium.googlesource.com/chromium/src/+/14a6bb723950b8e7bf74380ac079aad6433355ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -90 lines) Patch
M third_party/WebKit/Source/modules/indexeddb/IDBCursor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBIndex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBKeyPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBVersionChangeEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/MockWebIDBDatabase.h View 1 chunk +55 lines, -55 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
jsbell
dmurph@ - please take a look?
3 years, 8 months ago (2017-04-12 21:29:02 UTC) #3
dmurph
lgtm
3 years, 8 months ago (2017-04-12 21:48:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814253002/1
3 years, 8 months ago (2017-04-13 00:51:28 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 02:37:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14a6bb723950b8e7bf74380ac079...

Powered by Google App Engine
This is Rietveld 408576698