Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2808763007: IndexedDB: Clean up boilerplate when throwing TransactionInactiveError (Closed)

Created:
3 years, 8 months ago by jsbell
Modified:
3 years, 8 months ago
Reviewers:
dmurph
CC:
chromium-reviews, haraken, blink-reviews, jsbell+idb_chromium.org, cmumford
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Clean up boilerplate when throwing TransactionInactiveError Chrome's implementation provides different detailed error messages for the various API methods to distinguish between the transaction being merely inactive (between event dispatches) and finished (committed or aborted). Reduce the boilerplate in each method by letting the transaction introspect to provide the message. R=dmurph@chromium.org Review-Url: https://codereview.chromium.org/2808763007 Cr-Commit-Position: refs/heads/master@{#464450} Committed: https://chromium.googlesource.com/chromium/src/+/96df469774cc96620178f1e666754bdfb27868b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -225 lines) Patch
M third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp View 5 chunks +10 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBIndex.cpp View 6 chunks +12 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp View 13 chunks +26 lines, -117 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp View 1 chunk +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp View 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
jsbell
dmurph@ - please take a look?
3 years, 8 months ago (2017-04-12 22:03:58 UTC) #2
dmurph
lgtm
3 years, 8 months ago (2017-04-12 23:57:35 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2814253002 Patch 1). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-13 00:51:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808763007/1
3 years, 8 months ago (2017-04-13 17:11:03 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 17:24:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96df469774cc96620178f1e66675...

Powered by Google App Engine
This is Rietveld 408576698