IndexedDB: Fix mocks/comments following the great blink rename

third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 152 matching lines @@
   }
   if (!BackendDB()) {
     exception_state.ThrowDOMException(kInvalidStateError,
                                       IDBDatabase::kDatabaseClosedErrorMessage);
     return nullptr;
   }
 
   IDBRequest* request = IDBRequest::Create(script_state, IDBAny::Create(this),
                                            transaction_.Get());
   BackendDB()->Get(transaction_->Id(), Id(), IDBIndexMetadata::kInvalidId,
-                   key_range, false /* keyOnly */,
+                   key_range, /*key_only=*/false,
                    request->CreateWebCallbacks().release());
   return request;
 }
 
 IDBRequest* IDBObjectStore::getKey(ScriptState* script_state,
                                    const ScriptValue& key,
                                    ExceptionState& exception_state) {
   IDB_TRACE("IDBObjectStore::getKey");
   if (IsDeleted()) {
     exception_state.ThrowDOMException(
@@ skipping 23 matching lines @@
   }
   if (!BackendDB()) {
     exception_state.ThrowDOMException(kInvalidStateError,
                                       IDBDatabase::kDatabaseClosedErrorMessage);
     return nullptr;
   }
 
   IDBRequest* request = IDBRequest::Create(script_state, IDBAny::Create(this),
                                            transaction_.Get());
   BackendDB()->Get(transaction_->Id(), Id(), IDBIndexMetadata::kInvalidId,
-                   key_range, true /* keyOnly */,
+                   key_range, /*key_only=*/true,
                    request->CreateWebCallbacks().release());
   return request;
 }
 
 IDBRequest* IDBObjectStore::getAll(ScriptState* script_state,
                                    const ScriptValue& key_range,
                                    ExceptionState& exception_state) {
   return getAll(script_state, key_range, std::numeric_limits<uint32_t>::max(),
                 exception_state);
 }
@@ skipping 410 matching lines @@
   IDBRequest* request = IDBRequest::Create(script_state, IDBAny::Create(this),
                                            transaction_.Get());
   BackendDB()->Clear(transaction_->Id(), Id(),
                      request->CreateWebCallbacks().release());
   return request;
 }
 
 namespace {
 // This class creates the index keys for a given index by extracting
 // them from the SerializedScriptValue, for all the existing values in
-// the objectStore. It only needs to be kept alive by virtue of being
+// the object store. It only needs to be kept alive by virtue of being
 // a listener on an IDBRequest object, in the same way that JavaScript
 // cursor success handlers are kept alive.
 class IndexPopulator final : public EventListener {
  public:
   static IndexPopulator* Create(ScriptState* script_state,
                                 IDBDatabase* database,
                                 int64_t transaction_id,
                                 int64_t object_store_id,
                                 RefPtr<const IDBIndexMetadata> index_metadata) {
     return new IndexPopulator(script_state, database, transaction_id,
@@ skipping 41 matching lines @@
     ScriptState::Scope scope(script_state_.Get());
 
     IDBAny* cursor_any = request->ResultAsAny();
     IDBCursorWithValue* cursor = nullptr;
     if (cursor_any->GetType() == IDBAny::kIDBCursorWithValueType)
       cursor = cursor_any->IdbCursorWithValue();
 
     Vector<int64_t> index_ids;
     index_ids.push_back(IndexMetadata().id);
     if (cursor && !cursor->IsDeleted()) {
-      cursor->continueFunction(nullptr, nullptr, ASSERT_NO_EXCEPTION);
+      cursor->Continue(nullptr, nullptr, ASSERT_NO_EXCEPTION);
 
       IDBKey* primary_key = cursor->IdbPrimaryKey();
       ScriptValue value = cursor->value(script_state_.Get());
 
       IndexKeys index_keys;
       GenerateIndexKeysForValue(script_state_->GetIsolate(), IndexMetadata(),
                                 value, &index_keys);
 
       HeapVector<IndexKeys> index_keys_list;
       index_keys_list.push_back(index_keys);
@@ skipping 332 matching lines @@
 
   for (auto& it : index_map_) {
     IDBIndex* index = it.value;
     index->MarkDeleted();
   }
 }
 
 void IDBObjectStore::ClearIndexCache() {
   DCHECK(!transaction_->IsActive() || (IsDeleted() && IsNewlyCreated()));
 
-// There is no harm in having clearIndexCache() happen multiple times for
-// the same object. We assert that it is called once to uncover potential
-// object store accounting bugs.
 #if DCHECK_IS_ON()
+  // There is no harm in having ClearIndexCache() happen multiple times for
+  // the same object. We assert that it is called once to uncover potential
+  // object store accounting bugs.
   DCHECK(!clear_index_cache_called_);
   clear_index_cache_called_ = true;
 #endif  // DCHECK_IS_ON()
 
   index_map_.Clear();
 }
 
 void IDBObjectStore::RevertMetadata(
     RefPtr<IDBObjectStoreMetadata> old_metadata) {
   DCHECK(transaction_->IsVersionChange());
@@ skipping 40 matching lines @@
   deleted_index.RevertMetadata(std::move(old_index_metadata));
 }
 
 void IDBObjectStore::RenameIndex(int64_t index_id, const String& new_name) {
   DCHECK(transaction_->IsVersionChange());
   DCHECK(transaction_->IsActive());
 
   BackendDB()->RenameIndex(transaction_->Id(), Id(), index_id, new_name);
 
   auto metadata_iterator = metadata_->indexes.Find(index_id);
-  DCHECK_NE(metadata_iterator, metadata_->indexes.end()) << "Invalid indexId";
+  DCHECK_NE(metadata_iterator, metadata_->indexes.end()) << "Invalid index_id";
   const String& old_name = metadata_iterator->value->name;
 
   DCHECK(index_map_.Contains(old_name))
       << "The index had to be accessed in order to be renamed.";
   DCHECK(!index_map_.Contains(new_name));
   index_map_.Set(new_name, index_map_.Take(old_name));
 
   metadata_iterator->value->name = new_name;
 }
 
 int64_t IDBObjectStore::FindIndexId(const String& name) const {
   for (const auto& it : Metadata().indexes) {
     if (it.value->name == name) {
       DCHECK_NE(it.key, IDBIndexMetadata::kInvalidId);
       return it.key;
     }
   }
   return IDBIndexMetadata::kInvalidId;
 }
 
 WebIDBDatabase* IDBObjectStore::BackendDB() const {
   return transaction_->BackendDB();
 }
 
 }  // namespace blink