Add sorting to the Data Saver site breakdown

Add sorting to the Data Saver site breakdown

Add the ability to sort the Data Saver site breakdown by top usage and
top savings. Also, adjust the settings page to spec and to support RTL
layouts.

BUG=615560
Review-Url: https://codereview.chromium.org/2813923003
Cr-Commit-Position: refs/heads/master@{#464142}
Committed: https://chromium.googlesource.com/chromium/src/+/80ca3b65c939b4781c8b10be1aa447190400d9b9

[megjablon, 2017-04-11 21:45:06]

Description was changed from

==========
Add sorting to the Data Saver site breakdown

Add the ability to sort the Data Saver site breakdown by top usage and
top savings. Also adjust the settings page to spec.

BUG=615560
==========

to

==========
Add sorting to the Data Saver site breakdown

Add the ability to sort the Data Saver site breakdown by top usage and
top savings. Also, adjust the settings page to spec.

BUG=615560
==========

[megjablon, 2017-04-12 01:02:03]

Description was changed from

==========
Add sorting to the Data Saver site breakdown

Add the ability to sort the Data Saver site breakdown by top usage and
top savings. Also, adjust the settings page to spec.

BUG=615560
==========

to

==========
Add sorting to the Data Saver site breakdown

Add the ability to sort the Data Saver site breakdown by top usage and
top savings. Also, adjust the settings page to spec and to support RTL
layouts.

BUG=615560
==========

[megjablon, 2017-04-12 01:03:56]

megjablon@chromium.org changed reviewers:
+ dtrainor@chromium.org

[megjablon, 2017-04-12 01:03:56]

PTAL, thanks!

[David Trainor- moved to gerrit, 2017-04-12 16:42:52]

lgtm % nits

https://codereview.chromium.org/2813923003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java
(right):

https://codereview.chromium.org/2813923003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java:37:
private int mTextColor;
@ColorInt on these two?

https://codereview.chromium.org/2813923003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java:60:
final DataUsedComparator comp = new DataUsedComparator();
Inline this into Collections.sort?  Same with other places?  Or just make a
static up top you can always use in this file?

https://codereview.chromium.org/2813923003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java:93:
Drawable[] drawables = textView.getCompoundDrawables();
Should we add a getStartCompoundDrawable method?

https://codereview.chromium.org/2813923003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java:96:
drawables[0].mutate();
Mutate copies the internal state of the drawable right?  Do you know what this
does for a typical drawable here?  Just want to make sure it doesn't allocate
more memory for the underlying asset.  Just check imo.

[megjablon, 2017-04-12 18:52:01]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 18:52:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-04-12 18:54:45]

Thanks for the quick review!

https://codereview.chromium.org/2813923003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java
(right):

https://codereview.chromium.org/2813923003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java:37:
private int mTextColor;
On 2017/04/12 16:42:52, David Trainor-ping if over 24h wrote:
> @ColorInt on these two?

Done.

https://codereview.chromium.org/2813923003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java:60:
final DataUsedComparator comp = new DataUsedComparator();
On 2017/04/12 16:42:52, David Trainor-ping if over 24h wrote:
> Inline this into Collections.sort?  Same with other places?  Or just make a
> static up top you can always use in this file?

Done.

https://codereview.chromium.org/2813923003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java:93:
Drawable[] drawables = textView.getCompoundDrawables();
On 2017/04/12 16:42:52, David Trainor-ping if over 24h wrote:
> Should we add a getStartCompoundDrawable method?

Done.

https://codereview.chromium.org/2813923003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java:96:
drawables[0].mutate();
On 2017/04/12 16:42:52, David Trainor-ping if over 24h wrote:
> Mutate copies the internal state of the drawable right?  Do you know what this
> does for a typical drawable here?  Just want to make sure it doesn't allocate
> more memory for the underlying asset.  Just check imo.
"A mutable BitmapDrawable still shares its Bitmap with any other Drawable that
comes from the same resource." It just copies the BitmapState if the drawable
isn't already set to mutated.

[commit-bot: I haz the power, 2017-04-12 19:37:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 19:37:09]

Dry run: This issue passed the CQ dry run.

[megjablon, 2017-04-12 19:40:25]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2017-04-12 19:40:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2813923003/#ps60001
(title: "dtrainor comments")

[commit-bot: I haz the power, 2017-04-12 19:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 19:41:38]

This CL has an open dependency (Issue 2809123003 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[megjablon, 2017-04-12 19:51:44]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2017-04-12 19:51:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2813923003/#ps80001
(title: "remove dependency")

[commit-bot: I haz the power, 2017-04-12 19:52:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 20:46:41]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492026704071270,
"parent_rev": "c666c641ced98002aeb38515fe44f722b3714201", "commit_rev":
"80ca3b65c939b4781c8b10be1aa447190400d9b9"}

[commit-bot: I haz the power, 2017-04-12 20:47:36]

Description was changed from

==========
Add sorting to the Data Saver site breakdown

Add the ability to sort the Data Saver site breakdown by top usage and
top savings. Also, adjust the settings page to spec and to support RTL
layouts.

BUG=615560
==========

to

==========
Add sorting to the Data Saver site breakdown

Add the ability to sort the Data Saver site breakdown by top usage and
top savings. Also, adjust the settings page to spec and to support RTL
layouts.

BUG=615560

Review-Url: https://codereview.chromium.org/2813923003
Cr-Commit-Position: refs/heads/master@{#464142}
Committed:
https://chromium.googlesource.com/chromium/src/+/80ca3b65c939b4781c8b10be1aa4...
==========

[commit-bot: I haz the power, 2017-04-12 20:47:37]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/80ca3b65c939b4781c8b10be1aa4...