Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2815123003: Clear all DRP prefs on ClearDataSavingStatistics (Closed)

Created:
3 years, 8 months ago by megjablon
Modified:
3 years, 8 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear all DRP prefs on ClearDataSavingStatistics When Data Saver stats are reset via the settings page, all DRP related statistics should be erased. BUG=710651 Review-Url: https://codereview.chromium.org/2815123003 Cr-Commit-Position: refs/heads/master@{#464283} Committed: https://chromium.googlesource.com/chromium/src/+/d6ad7119d64c9b6d62eaf315eab570cd476b2fcf

Patch Set 1 #

Patch Set 2 : add unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -115 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats_unittest.cc View 1 24 chunks +145 lines, -115 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
megjablon
3 years, 8 months ago (2017-04-12 23:05:39 UTC) #6
RyanSturm
Should you test these in some way? Not sure if it's worth it. Otherwise lgtm.
3 years, 8 months ago (2017-04-12 23:12:19 UTC) #7
megjablon
On 2017/04/12 23:12:19, Ryan Sturm wrote: > Should you test these in some way? Not ...
3 years, 8 months ago (2017-04-13 00:32:17 UTC) #9
RyanSturm
lgtm
3 years, 8 months ago (2017-04-13 00:38:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2815123003/20001
3 years, 8 months ago (2017-04-13 02:19:19 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 03:48:49 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d6ad7119d64c9b6d62eaf315eab5...

Powered by Google App Engine
This is Rietveld 408576698