Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3765)

Unified Diff: chrome/android/java/res/layout/data_usage_breakdown.xml

Issue 2813923003: Add sorting to the Data Saver site breakdown (Closed)
Patch Set: remove dependency Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/data_usage_breakdown.xml
diff --git a/chrome/android/java/res/layout/data_usage_breakdown.xml b/chrome/android/java/res/layout/data_usage_breakdown.xml
index fc49a18ae40e1c44ee361131f1a8202dc29def3f..dd2f710a3e76cdf59bcd324e89322a3baf58d949 100644
--- a/chrome/android/java/res/layout/data_usage_breakdown.xml
+++ b/chrome/android/java/res/layout/data_usage_breakdown.xml
@@ -14,10 +14,11 @@
<TextView
android:id="@+id/data_reduction_data_usage_breakdown_title"
- android:layout_width="match_parent"
+ android:layout_width="wrap_content"
android:layout_height="wrap_content"
- android:layout_marginTop="26dp"
- android:paddingBottom="10dp"
+ android:layout_gravity="start"
+ android:paddingBottom="12dp"
+ android:paddingTop="26dp"
android:singleLine="true"
android:text="@string/data_reduction_data_usage_breakdown_title"
android:textAppearance="@style/PreferenceCategoryTextStyle" />
@@ -33,30 +34,34 @@
<TableRow
android:id="@+id/data_reduction_proxy_breakdown_table_labels"
android:layout_height="wrap_content"
- android:layout_width="match_parent"
- android:orientation="horizontal">
+ android:layout_width="match_parent">
<TextView
android:text="@string/data_reduction_breakdown_site_title"
android:layout_width="0dp"
- android:layout_weight="1"
- android:textColor="?android:attr/textColorSecondary"
+ android:layout_weight="0"
+ android:layout_gravity="start"
+ android:textColor="@color/data_reduction_breakdown_light_text_color"
style="@style/DataUsageBreakdownColumnLabel" />
<TextView
+ android:id="@+id/data_reduction_breakdown_used_title"
android:text="@string/data_reduction_breakdown_used_title"
android:layout_width="wrap_content"
+ android:layout_marginStart="24dp"
+ android:drawablePadding="3dp"
+ android:drawableStart="@drawable/data_reduction_breakdown_sort_arrow"
android:gravity="end"
- android:paddingStart="10dp"
- android:textColor="?android:attr/textColorPrimary"
style="@style/DataUsageBreakdownColumnLabel" />
<TextView
+ android:id="@+id/data_reduction_breakdown_saved_title"
android:text="@string/data_reduction_breakdown_saved_title"
android:layout_width="wrap_content"
+ android:layout_marginStart="24dp"
+ android:drawablePadding="3dp"
+ android:drawableStart="@drawable/data_reduction_breakdown_sort_arrow"
android:gravity="end"
- android:paddingStart="24dp"
- android:textColor="?android:attr/textColorSecondary"
style="@style/DataUsageBreakdownColumnLabel" />
</TableRow>

Powered by Google App Engine
This is Rietveld 408576698