Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2813873002: Modify some more GC layout tests to work with Ignition (Closed)

Created:
3 years, 8 months ago by Leszek Swirski
Modified:
3 years, 8 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, jkarlin+watch_chromium.org, cmumford
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify some more GC layout tests to work with Ignition In Ignition, dead temporary registers holding call arguments may still be holding on to old values which should have been GCed. Perform these calls inside function closures so that their stacks (and these temporary registers) are cleaned up before calling gc(). This was previously fixed in https://codereview.chromium.org/1972943002 and https://codereview.chromium.org/1950613005, but appeared again when Ignition added implicit undefined registers and started overwriting fewer registers in global calls. BUG=chromium:595672 Review-Url: https://codereview.chromium.org/2813873002 Cr-Commit-Position: refs/heads/master@{#463636} Committed: https://chromium.googlesource.com/chromium/src/+/2304169a1b293adf38af7f08f325e3d546a06e0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/netinfo/gc-unused-listeners.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/cursor-request-cycle.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/storage/indexeddb/key-cursor-request-cycle.html View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Leszek Swirski
Hey Ross, As discussed, PTAL.
3 years, 8 months ago (2017-04-11 14:12:58 UTC) #4
rmcilroy
lgtm
3 years, 8 months ago (2017-04-11 14:18:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813873002/1
3 years, 8 months ago (2017-04-11 14:19:19 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 15:14:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2304169a1b293adf38af7f08f325...

Powered by Google App Engine
This is Rietveld 408576698