Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: third_party/WebKit/LayoutTests/storage/indexeddb/key-cursor-request-cycle.html

Issue 2813873002: Modify some more GC layout tests to work with Ignition (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/storage/indexeddb/cursor-request-cycle.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/storage/indexeddb/key-cursor-request-cycle.html
diff --git a/third_party/WebKit/LayoutTests/storage/indexeddb/key-cursor-request-cycle.html b/third_party/WebKit/LayoutTests/storage/indexeddb/key-cursor-request-cycle.html
index 4b24ace259f4399614251f4389b773d6bbf62bfc..a0e99fa3d6e2cccd4010929da562e58807d4994b 100644
--- a/third_party/WebKit/LayoutTests/storage/indexeddb/key-cursor-request-cycle.html
+++ b/third_party/WebKit/LayoutTests/storage/indexeddb/key-cursor-request-cycle.html
@@ -70,7 +70,10 @@ function onOpen(evt)
preamble(evt);
shouldBeEqualToString("cursor.key", "key2");
- cursorObservation = internals.observeGC(cursor);
+ // Access objects in an inner function to avoid references to
+ // objects remaining live on this function's stack frame
+ // (http://crbug.com/595672/).
+ (() => { cursorObservation = internals.observeGC(cursor); })();
evalAndLog("cursor = null");
evalAndLog("gc()");
shouldBeTrue("cursorRequestObservation.wasCollected");
« no previous file with comments | « third_party/WebKit/LayoutTests/storage/indexeddb/cursor-request-cycle.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698