Modifies few gc related layout tests to work with ignition.

Modifies few gc related layout tests to work with ignition.

In ignition dead temporary registers may hold references to objects
preventing GC from collecting them. It is expensive to clear the dead
registers and there is no noticable impact on heap size. This cl
updates some of the layout tests to work with ignition.

BUG=chromium:595672, v8:4280
LOG=N

Committed: https://crrev.com/f61e5d398556470fc7c79e0c2ad1aa16613905c2
Cr-Commit-Position: refs/heads/master@{#394086}

[mythria, 2016-05-12 13:31:22]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 13:31:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972943002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972943002/1

[mythria, 2016-05-12 13:34:49]

mythria@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[mythria, 2016-05-12 13:34:49]

PTAL. This is to fix layout tests that are not related to observeGC.

[commit-bot: I haz the power, 2016-05-12 14:26:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 14:26:54]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-05-13 11:29:37]

Also please create a CL which removes these tests from the
TestExpectationsIgnition file on V8 so that we can land that once this lands.

https://codereview.chromium.org/1972943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html
(right):

https://codereview.chromium.org/1972943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html:20:
// in dead registers when using ignition (chromium:595672)
/s/Perform all assignments in a function/Do initialization work in an inner
function/
/s/in dead registers/remaining live on this function's stack frame/
/s/(chromium:595672)/ - http://crbug.com/595672/ 

And thoughout.

[mythria, 2016-05-16 09:56:59]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-16 09:57:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972943002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972943002/20001

[commit-bot: I haz the power, 2016-05-16 11:03:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 11:03:09]

Dry run: This issue passed the CQ dry run.

[mythria, 2016-05-16 11:15:10]

Thanks. I fixed it.
PTAL.

Thanks,
Mythri

https://codereview.chromium.org/1972943002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html
(right):

https://codereview.chromium.org/1972943002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html:20:
// in dead registers when using ignition (chromium:595672)
On 2016/05/13 11:29:37, rmcilroy wrote:
> /s/Perform all assignments in a function/Do initialization work in an inner
> function/
> /s/in dead registers/remaining live on this function's stack frame/
> /s/(chromium:595672)/ - http://crbug.com/595672/ 
> 
> And thoughout.

Done.

[rmcilroy, 2016-05-16 13:06:33]

LGTM, but please have the CL which removes these tests from the
TestExpectationsIgnition file on V8 ready for once this lands.

[mythria, 2016-05-17 08:54:38]

The CQ bit was checked by mythria@chromium.org

[commit-bot: I haz the power, 2016-05-17 08:54:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972943002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972943002/20001

[commit-bot: I haz the power, 2016-05-17 08:58:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-17 09:00:32]

Description was changed from

==========
Modifies few gc related layout tests to work with ignition.

In ignition dead temporary registers may hold references to objects
preventing GC from collecting them. It is expensive to clear the dead
registers and there is no noticable impact on heap size. This cl
updates some of the layout tests to work with ignition.

BUG=chromium:595672,v8:4280
LOG=N
==========

to

==========
Modifies few gc related layout tests to work with ignition.

In ignition dead temporary registers may hold references to objects
preventing GC from collecting them. It is expensive to clear the dead
registers and there is no noticable impact on heap size. This cl
updates some of the layout tests to work with ignition.

BUG=chromium:595672,v8:4280
LOG=N

Committed: https://crrev.com/f61e5d398556470fc7c79e0c2ad1aa16613905c2
Cr-Commit-Position: refs/heads/master@{#394086}
==========

[commit-bot: I haz the power, 2016-05-17 09:00:33]

Patchset 2 (id:??) landed as
https://crrev.com/f61e5d398556470fc7c79e0c2ad1aa16613905c2
Cr-Commit-Position: refs/heads/master@{#394086}