Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2813583002: Support calc(...) in ConsumeAngleOrPercent / for conic-gradient (Closed)

Created:
3 years, 8 months ago by fs
Modified:
3 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Support calc(...) in ConsumeAngleOrPercent / for conic-gradient Because of the explicit check for <percentage-token>, calc(...) would not be properly handled for percentages. CSSGradientValue also wasn't checking for calc() values when evaluating stops. Rewrite ConsumeAngleOrPercent in a vein similar to ConsumeLengthOrPercent. Make CSSPrimitiveValue::IsAngle() consider resolved type, and update CSSRotation TypedOM implementation to counter this. BUG=709730 Review-Url: https://codereview.chromium.org/2813583002 Cr-Commit-Position: refs/heads/master@{#463585} Committed: https://chromium.googlesource.com/chromium/src/+/cc50825cf637990a4edfa90c9610ad072885c74d

Patch Set 1 #

Patch Set 2 : Fix up IsAngle #

Total comments: 6

Patch Set 3 : TypedOM CSSRotation fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/fast/gradients/conic-gradient-parsing.html View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp View 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 29 (19 generated)
f(malita)
https://codereview.chromium.org/2813583002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp (right): https://codereview.chromium.org/2813583002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp#newcode948 third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp:948: CalcParser calc_parser(range, value_range); Both ConsumePercent and ConsumeAngle perform type ...
3 years, 8 months ago (2017-04-10 14:07:03 UTC) #10
fs
https://codereview.chromium.org/2813583002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp (right): https://codereview.chromium.org/2813583002/diff/20001/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp#newcode948 third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp:948: CalcParser calc_parser(range, value_range); On 2017/04/10 at 14:07:03, f(malita) wrote: ...
3 years, 8 months ago (2017-04-10 14:09:08 UTC) #11
f(malita)
https://codereview.chromium.org/2813583002/diff/20001/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h File third_party/WebKit/Source/core/css/CSSPrimitiveValue.h (right): https://codereview.chromium.org/2813583002/diff/20001/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h#newcode167 third_party/WebKit/Source/core/css/CSSPrimitiveValue.h:167: bool IsAngle() const { return IsAngle(TypeWithCalcResolved()); } All IsFoo() ...
3 years, 8 months ago (2017-04-10 14:16:26 UTC) #12
fs
https://codereview.chromium.org/2813583002/diff/20001/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h File third_party/WebKit/Source/core/css/CSSPrimitiveValue.h (right): https://codereview.chromium.org/2813583002/diff/20001/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h#newcode167 third_party/WebKit/Source/core/css/CSSPrimitiveValue.h:167: bool IsAngle() const { return IsAngle(TypeWithCalcResolved()); } On 2017/04/10 ...
3 years, 8 months ago (2017-04-10 14:22:58 UTC) #13
f(malita)
On 2017/04/10 14:22:58, fs wrote: > https://codereview.chromium.org/2813583002/diff/20001/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h > File third_party/WebKit/Source/core/css/CSSPrimitiveValue.h (right): > > https://codereview.chromium.org/2813583002/diff/20001/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h#newcode167 > ...
3 years, 8 months ago (2017-04-10 14:25:09 UTC) #14
fs
3 years, 8 months ago (2017-04-10 15:12:15 UTC) #18
meade_UTC10
lgtm
3 years, 8 months ago (2017-04-11 05:03:28 UTC) #21
alancutter (OOO until 2018)
lgtm
3 years, 8 months ago (2017-04-11 05:28:55 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813583002/40001
3 years, 8 months ago (2017-04-11 09:15:11 UTC) #26
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 09:24:37 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cc50825cf637990a4edfa90c9610...

Powered by Google App Engine
This is Rietveld 408576698