Support calc(...) in ConsumeAngleOrPercent / for conic-gradient

third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

 /*
  * (C) 1999-2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 146 matching lines @@
     kUResolution,
     kUOther
   };
   static UnitCategory UnitTypeToUnitCategory(UnitType);
   static float ClampToCSSLengthRange(double);
 
   static bool IsAngle(UnitType unit) {
     return unit == UnitType::kDegrees || unit == UnitType::kRadians ||
            unit == UnitType::kGradians || unit == UnitType::kTurns;
   }
-  bool IsAngle() const { return IsAngle(GetType()); }
+  bool IsAngle() const { return IsAngle(TypeWithCalcResolved()); }

[f(malita), 2017/04/10 14:16:26]

All IsFoo() helpers seem to ignore calc values at this point.  For consistency,
I suggest we leave IsAngle() as-is for now and update the test in
CSSGradientValue::AddStops() instead:

  stop.offset_->IsAngle() =>
CSSPrimitiveValue::IsAngle(stop.offset_->TypeWithCalcResolved())

[fs, 2017/04/10 14:22:58]

Hmm, IsLength, IsNumber and IsPercentage (the non-static versions) all use
TypeWithCalcResolved()?

   bool IsFontRelativeLength() const {
     return GetType() == UnitType::kQuirkyEms || GetType() == UnitType::kEms ||
            GetType() == UnitType::kExs || GetType() == UnitType::kRems ||
            GetType() == UnitType::kChs;
   }
   bool IsQuirkyEms() const { return GetType() == UnitType::kQuirkyEms; }
   bool IsViewportPercentageLength() const {
     return IsViewportPercentageLength(GetType());
   }
   static bool IsViewportPercentageLength(UnitType type) {
@@ skipping 157 matching lines @@
 short CSSPrimitiveValue::ComputeLength(const CSSToLengthConversionData&) const;
 
 template <>
 float CSSPrimitiveValue::ComputeLength(const CSSToLengthConversionData&) const;
 
 template <>
 double CSSPrimitiveValue::ComputeLength(const CSSToLengthConversionData&) const;
 }  // namespace blink
 
 #endif  // CSSPrimitiveValue_h