third_party/WebKit/Source/core/css/CSSPrimitiveValue.h - Issue 2813583002: Support calc(...) in ConsumeAngleOrPercent / for conic-gradient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

Issue 2813583002: Support calc(...) in ConsumeAngleOrPercent / for conic-gradient (Closed)

Patch Set: TypedOM CSSRotation fixup Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

index a0c694e6b74dd6b92d2a4b438d94f508d3d8dbe2..ab683277c610681fdddbb27feb9fdd50369b0de5 100644

--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

@@ -164,7 +164,7 @@ class CORE_EXPORT CSSPrimitiveValue : public CSSValue {

return unit == UnitType::kDegrees || unit == UnitType::kRadians ||

unit == UnitType::kGradians || unit == UnitType::kTurns;

}

- bool IsAngle() const { return IsAngle(GetType()); }

+ bool IsAngle() const { return IsAngle(TypeWithCalcResolved()); }

bool IsFontRelativeLength() const {

return GetType() == UnitType::kQuirkyEms || GetType() == UnitType::kEms ||

GetType() == UnitType::kExs || GetType() == UnitType::kRems ||