Replace elevation required bool with an enum.

Replace elevation required bool with an enum.

BUG=690020
Review-Url: https://codereview.chromium.org/2813253002
Cr-Commit-Position: refs/heads/master@{#464226}
Committed: https://chromium.googlesource.com/chromium/src/+/daf91016aa4560f3c0f72d50eee762eed996fc0e

[ftirelo, 2017-04-12 18:03:20]

Description was changed from

==========
Replace elevation required bool with an enum.

BUG=
==========

to

==========
Replace elevation required bool with an enum.

BUG=690020
==========

[ftirelo, 2017-04-12 18:04:24]

ftirelo@chromium.org changed reviewers:
+ robertshield@chromium.org

[ftirelo, 2017-04-12 18:04:24]

This is a follow up of crrev/2780873002.

[robertshield, 2017-04-12 18:32:45]

lgtm

[ftirelo, 2017-04-12 19:47:59]

ftirelo@chromium.org changed reviewers:
+ jialiul@chromium.org, wfh@chromium.org

[ftirelo, 2017-04-12 19:47:59]

+jialiul@ for OWNERS.
+wfh@ for SECURITY_OWNERS.

[Jialiu Lin, 2017-04-12 19:57:09]

lgtm

[Will Harris, 2017-04-12 19:58:59]

https://codereview.chromium.org/2813253002/diff/1/components/chrome_cleaner/p...
File components/chrome_cleaner/public/interfaces/chrome_prompt.mojom (right):

https://codereview.chromium.org/2813253002/diff/1/components/chrome_cleaner/p...
components/chrome_cleaner/public/interfaces/chrome_prompt.mojom:37: REQUIRED =
1,
what other values are likely to be added to this enum in future?

[ftirelo, 2017-04-12 20:14:15]

https://codereview.chromium.org/2813253002/diff/1/components/chrome_cleaner/p...
File components/chrome_cleaner/public/interfaces/chrome_prompt.mojom (right):

https://codereview.chromium.org/2813253002/diff/1/components/chrome_cleaner/p...
components/chrome_cleaner/public/interfaces/chrome_prompt.mojom:37: REQUIRED =
1,
On 2017/04/12 19:58:59, Will Harris wrote:
> what other values are likely to be added to this enum in future?

For the moment, the main purpose of this enum is to make the param
self-documented (ElevationStatus::REQUIRED instead /*elevation_require=*/true).

Eventually, we will investigate other integrity levels the cleaner could run on
(like medium integrity maybe), but not in the near future.

[Will Harris, 2017-04-12 20:15:16]

lgtm then, but if you decide to add other elevation levels please come back for
a security review. thanks!

[ftirelo, 2017-04-12 20:20:27]

On 2017/04/12 20:15:16, Will Harris wrote:
> lgtm then, but if you decide to add other elevation levels please come back
for
> a security review. thanks!

Will do.

[ftirelo, 2017-04-12 20:20:37]

Thanks for the reviews!

On 2017/04/12 20:20:27, ftirelo wrote:
> On 2017/04/12 20:15:16, Will Harris wrote:
> > lgtm then, but if you decide to add other elevation levels please come back
> for
> > a security review. thanks!
> 
> Will do.

[ftirelo, 2017-04-12 20:20:43]

The CQ bit was checked by ftirelo@chromium.org

[commit-bot: I haz the power, 2017-04-12 20:21:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 22:59:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 22:59:54]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ftirelo, 2017-04-13 00:35:05]

The CQ bit was checked by ftirelo@chromium.org

[commit-bot: I haz the power, 2017-04-13 00:37:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 01:12:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492043705994910, "parent_rev":
"eb38d9eecf60aced7882a7f962eecd743efd2a91", "commit_rev":
"daf91016aa4560f3c0f72d50eee762eed996fc0e"}

[commit-bot: I haz the power, 2017-04-13 01:13:28]

Description was changed from

==========
Replace elevation required bool with an enum.

BUG=690020
==========

to

==========
Replace elevation required bool with an enum.

BUG=690020

Review-Url: https://codereview.chromium.org/2813253002
Cr-Commit-Position: refs/heads/master@{#464226}
Committed:
https://chromium.googlesource.com/chromium/src/+/daf91016aa4560f3c0f72d50eee7...
==========

[commit-bot: I haz the power, 2017-04-13 01:13:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/daf91016aa4560f3c0f72d50eee7...