Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: components/chrome_cleaner/public/interfaces/chrome_prompt.mojom

Issue 2813253002: Replace elevation required bool with an enum. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All Rights Reserved. 1 // Copyright 2017 The Chromium Authors. All Rights Reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module chrome_cleaner.mojom; 5 module chrome_cleaner.mojom;
6 6
7 // The behaviours that have been observed for a given UwS. 7 // The behaviours that have been observed for a given UwS.
8 struct ObservedBehaviours { 8 struct ObservedBehaviours {
9 bool ad_injector; 9 bool ad_injector;
10 bool settings_hijacker; 10 bool settings_hijacker;
(...skipping 12 matching lines...) Expand all
23 23
24 // Behaviors observed for this UwS to be presented to the user in the Chrome 24 // Behaviors observed for this UwS to be presented to the user in the Chrome
25 // prompt. 25 // prompt.
26 ObservedBehaviours observed_behaviours; 26 ObservedBehaviours observed_behaviours;
27 27
28 // List of fully-qualified paths of the files that will be deleted by the 28 // List of fully-qualified paths of the files that will be deleted by the
29 // Chrome Cleanup Tool for this unwanted software. 29 // Chrome Cleanup Tool for this unwanted software.
30 array<string> files_to_delete; 30 array<string> files_to_delete;
31 }; 31 };
32 32
33 // Indicates if elevation will be required for cleanup.
34 [Extensible]
35 enum ElevationStatus {
36 NOT_REQUIRED = 0,
37 REQUIRED = 1,
Will Harris 2017/04/12 19:58:59 what other values are likely to be added to this e
ftirelo 2017/04/12 20:14:15 For the moment, the main purpose of this enum is t
38 };
39
33 [Extensible] 40 [Extensible]
34 enum PromptAcceptance { 41 enum PromptAcceptance {
35 UNSPECIFIED = 0, 42 UNSPECIFIED = 0,
36 // The Chrome prompt was not shown to the user (for example, due to an 43 // The Chrome prompt was not shown to the user (for example, due to an
37 // experiment run that shouldn't prompt the user or because the user has 44 // experiment run that shouldn't prompt the user or because the user has
38 // been prompted recently). 45 // been prompted recently).
39 NOT_SHOWN = 1, 46 NOT_SHOWN = 1,
40 // The user explicitly accepted the Chrome prompt, but didn't opt into 47 // The user explicitly accepted the Chrome prompt, but didn't opt into
41 // uploading logs to Google. 48 // uploading logs to Google.
42 ACCEPTED_WITHOUT_LOGS = 2, 49 ACCEPTED_WITHOUT_LOGS = 2,
43 // The user explicitly accepted the Chrome prompt and also opted into 50 // The user explicitly accepted the Chrome prompt and also opted into
44 // uploading logs to Google. 51 // uploading logs to Google.
45 ACCEPTED_WITH_LOGS = 3, 52 ACCEPTED_WITH_LOGS = 3,
46 // The user explicitly denied the Chrome prompt. 53 // The user explicitly denied the Chrome prompt.
47 DENIED = 4, 54 DENIED = 4,
48 // The user didn't interact with the Chrome prompt after a while. 55 // The user didn't interact with the Chrome prompt after a while.
49 IGNORED = 5, 56 IGNORED = 5,
50 }; 57 };
51 58
52 // Service provided by Chrome to prompt the user to run the Chrome Cleanup Tool 59 // Service provided by Chrome to prompt the user to run the Chrome Cleanup Tool
53 // if unwanted software is detected on the system. This service is used by the 60 // if unwanted software is detected on the system. This service is used by the
54 // Software Reporter Tool so that all user interaction is provided by Chrome. 61 // Software Reporter Tool so that all user interaction is provided by Chrome.
55 interface ChromePrompt { 62 interface ChromePrompt {
56 // Params: 63 // Params:
57 // - removable_uws_found: the list of UwS detected by the reporter; 64 // - removable_uws_found: the list of UwS detected by the reporter;
58 // - elevation_required: if the cleaner will need to run in elevated mode. 65 // - elevation_status: if the cleaner will need to run in elevated mode.
59 // Returns: 66 // Returns:
60 // - prompt_acceptance: indicates if the user accepted the prompt; if the 67 // - prompt_acceptance: indicates if the user accepted the prompt; if the
61 // prompt is accepted, it also indicates if logs 68 // prompt is accepted, it also indicates if logs
62 // uploading is allowed. 69 // uploading is allowed.
63 PromptUser(array<UwS> removable_uws_found, bool elevation_required) 70 PromptUser(array<UwS> removable_uws_found, ElevationStatus elevation_status)
64 => (PromptAcceptance prompt_acceptance); 71 => (PromptAcceptance prompt_acceptance);
65 }; 72 };
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698