Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: components/chrome_cleaner/public/interfaces/chrome_prompt.mojom

Issue 2813253002: Replace elevation required bool with an enum. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/chrome_cleaner/public/interfaces/chrome_prompt.mojom
diff --git a/components/chrome_cleaner/public/interfaces/chrome_prompt.mojom b/components/chrome_cleaner/public/interfaces/chrome_prompt.mojom
index 04d986e00b81d19ca501c9e47d08019534190738..7458a8e3f67c82eec31213fa5f2537612daa7fa2 100644
--- a/components/chrome_cleaner/public/interfaces/chrome_prompt.mojom
+++ b/components/chrome_cleaner/public/interfaces/chrome_prompt.mojom
@@ -30,6 +30,13 @@ struct UwS {
array<string> files_to_delete;
};
+// Indicates if elevation will be required for cleanup.
+[Extensible]
+enum ElevationStatus {
+ NOT_REQUIRED = 0,
+ REQUIRED = 1,
Will Harris 2017/04/12 19:58:59 what other values are likely to be added to this e
ftirelo 2017/04/12 20:14:15 For the moment, the main purpose of this enum is t
+};
+
[Extensible]
enum PromptAcceptance {
UNSPECIFIED = 0,
@@ -55,11 +62,11 @@ enum PromptAcceptance {
interface ChromePrompt {
// Params:
// - removable_uws_found: the list of UwS detected by the reporter;
- // - elevation_required: if the cleaner will need to run in elevated mode.
+ // - elevation_status: if the cleaner will need to run in elevated mode.
// Returns:
// - prompt_acceptance: indicates if the user accepted the prompt; if the
// prompt is accepted, it also indicates if logs
// uploading is allowed.
- PromptUser(array<UwS> removable_uws_found, bool elevation_required)
+ PromptUser(array<UwS> removable_uws_found, ElevationStatus elevation_status)
=> (PromptAcceptance prompt_acceptance);
};
« no previous file with comments | « chrome/browser/safe_browsing/srt_fetcher_browsertest_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698